Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace offchain metadata with IPFS CID #255

Merged
merged 10 commits into from
Apr 23, 2024
Merged

Conversation

lrazovic
Copy link
Member

@lrazovic lrazovic commented Apr 23, 2024

What?

Replace the offchain_information_hash with policy_ipfs_cid. This IPFS CID will be used by the Credential Verify to verify a credential against the project specific policy.

An IPFS CID looks like: QmeuJ24ffwLAZppQcgcggJs3n689bewednYkuc8Bx5Gngz and you can access to its content using any IPFS gateway, like https://cloudflare-ipfs.com/ipfs/QmeuJ24ffwLAZppQcgcggJs3n689bewednYkuc8Bx5Gngz.

@lrazovic lrazovic self-assigned this Apr 23, 2024
@lrazovic lrazovic requested a review from JuaniRios April 23, 2024 12:59
Copy link
Contributor

@JuaniRios JuaniRios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lrazovic lrazovic marked this pull request as ready for review April 23, 2024 13:08
@lrazovic lrazovic requested a review from vstam1 April 23, 2024 13:08
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lrazovic lrazovic merged commit 58f4807 into main Apr 23, 2024
@lrazovic lrazovic deleted the leo/replace-offchain-metadata branch April 23, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants