Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ test evaluation bond cannot be used on another project participation #257

Merged
merged 1 commit into from
Apr 24, 2024
Merged

✅ test evaluation bond cannot be used on another project participation #257

merged 1 commit into from
Apr 24, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Apr 23, 2024 •
edited
Loading

What?

  • Add test that we cannot use evaluation bond of project x for project y

How?

  • One test in each bids,community, and remainder modules

@JuaniRios Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios force-pushed the 04-23-_test_evaluation_bond_cannot_be_used_on_another_project_participation branch from 6e9af6e to 72425f4 Compare April 24, 2024 12:59
@JuaniRios JuaniRios self-assigned this Apr 24, 2024
@JuaniRios JuaniRios marked this pull request as ready for review April 24, 2024 12:59
@JuaniRios JuaniRios force-pushed the 04-23-_test_evaluation_bond_cannot_be_used_on_another_project_participation branch from 72425f4 to edc35e0 Compare April 24, 2024 13:14
lrazovic
lrazovic approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see more tests - LGTM!

@JuaniRios JuaniRios merged commit 6180a07 into main Apr 24, 2024
@JuaniRios JuaniRios deleted the 04-23-_test_evaluation_bond_cannot_be_used_on_another_project_participation branch April 24, 2024 13:18
@JuaniRios Graphite App
Copy link
Contributor Author

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic