Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leo/restrict token audiance #258

Merged
merged 13 commits into from
Apr 25, 2024
Merged

Leo/restrict token audiance #258

merged 13 commits into from
Apr 25, 2024

Conversation

lrazovic
Copy link
Member

@lrazovic lrazovic commented Apr 24, 2024 •
edited by JuaniRios
Loading

What

  • Add project policy checks for evaluation/participation extrinsics

Why

  • Missing feature for MVP

How

  • Compare the policy in the project metadata with the one coming from the JWT

Testing

  • One added test in each evaluation/participation module

lrazovic
lrazovic commented Apr 24, 2024
View reviewed changes
pallets/funding/src/lib.rs Outdated Show resolved Hide resolved
JuaniRios
JuaniRios reviewed Apr 24, 2024
View reviewed changes
pallets/funding/src/lib.rs Outdated Show resolved Hide resolved
polimec-common/common/src/credentials/mod.rs Show resolved Hide resolved
polimec-common/test-utils/src/lib.rs Show resolved Hide resolved
@JuaniRios JuaniRios self-assigned this Apr 25, 2024
@JuaniRios JuaniRios requested a review from vstam1 April 25, 2024 08:09
@JuaniRios
tests
3877df4
@JuaniRios
Merge branch 'main' into leo/restrict-token-audiance
e3dbf3a 
# Conflicts:
#	pallets/funding/src/tests/4_community.rs
#	pallets/funding/src/tests/5_remainder.rs
@JuaniRios
fixes
18d6e85
@JuaniRios JuaniRios marked this pull request as ready for review April 25, 2024 08:17
vstam1
vstam1 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, only one small question about dispenser benchmarks.

pallets/dispenser/src/benchmarking.rs Outdated
@@ -33,6 +33,7 @@ fn assert_last_event<T: Config>(generic_event: <T as Config>::RuntimeEvent) {
#[benchmarks]
mod benchmarks {
use super::*;
use polimec_common_test_utils::get_mock_jwt_with_cid;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this breaks the dispenser benchmarks as code is still using get_mock_jwt or it is an unnecessary import?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an unnecessary import fcac9f4

@lrazovic lrazovic merged commit 629a750 into main Apr 25, 2024
@lrazovic lrazovic deleted the leo/restrict-token-audiance branch April 25, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuaniRios JuaniRios JuaniRios left review comments

@vstam1 vstam1 vstam1 approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lrazovic @vstam1 @JuaniRios