Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ New decimals community test #277

Merged
merged 1 commit into from
May 2, 2024
Merged

✅ New decimals community test #277

merged 1 commit into from
May 2, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented May 1, 2024 •
edited
Loading

What?

  • Add a test for checking a wide range of decimals for CTs work as intended.

Why?

  • We might have unexpected bugs when the decimals are too high or too low

How?

  • Similar to the auction test different_decimals_ct_works_as_expected

@JuaniRios JuaniRios mentioned this pull request May 1, 2024
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented May 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios force-pushed the 05-01-new_decimals_community_test branch from c15e2fc to a672596 Compare May 1, 2024 12:56
@JuaniRios JuaniRios force-pushed the 04-30-new_decimals_auction_test branch from 7c8f2f1 to 695dea9 Compare May 1, 2024 12:56
@JuaniRios JuaniRios force-pushed the 05-01-new_decimals_community_test branch from a672596 to d41baf2 Compare May 1, 2024 12:56
@JuaniRios JuaniRios mentioned this pull request May 1, 2024
Merged
@JuaniRios JuaniRios changed the title new decimals community test ✅ New decimals community test May 1, 2024
@JuaniRios JuaniRios self-assigned this May 1, 2024
@JuaniRios JuaniRios requested review from lrazovic and vstam1 May 1, 2024 13:02
This was referenced May 1, 2024
Merged
Merged
@JuaniRios JuaniRios marked this pull request as ready for review May 1, 2024 13:27
vstam1
vstam1 reviewed May 2, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test logic looks good. Please take a look at the dbg statements -> replace with some assets and check the comments for correctness. Might still be some copy pasta from auction test.

pallets/funding/src/tests/4_community.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 04-30-new_decimals_auction_test branch from 695dea9 to b33d996 Compare May 2, 2024 07:53
@JuaniRios JuaniRios force-pushed the 05-01-new_decimals_community_test branch 4 times, most recently from 92e2722 to 31f9e4f Compare May 2, 2024 07:59
@JuaniRios JuaniRios requested a review from vstam1 May 2, 2024 08:15
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented May 2, 2024 •
edited
Loading

Merge activity

  • May 2, 5:12 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • May 2, 5:13 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 2, 5:15 AM EDT: @JuaniRios merged this pull request with Graphite.

Base automatically changed from 04-30-new_decimals_auction_test to main May 2, 2024 09:13
@JuaniRios JuaniRios force-pushed the 05-01-new_decimals_community_test branch from 31f9e4f to 50a8de5 Compare May 2, 2024 09:13
@JuaniRios JuaniRios merged commit 2ad9634 into main May 2, 2024
@JuaniRios JuaniRios deleted the 05-01-new_decimals_community_test branch May 2, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@lrazovic lrazovic Awaiting requested review from lrazovic

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @vstam1