Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional mins on ticket sizes #283

Merged
merged 1 commit into from
May 6, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented May 6, 2024

What?

  • Make lower ticket bounds non-optional
  • Add min low bound of 1USD for contributions

Why?

  • The 1USD bound was discussed and agreed with Luca
  • Since both tickets now have a required lower bound, makes no sense to keep it optional since it will never be accepted when None

How?

  • Remove all references to Option on the lower bound, and add a check for 1USD on the ticket size in project metadata validation

Testing?

In a future PR

Anything Else?

Fixes of all the other tests in the next PR

Copy link
Contributor Author

JuaniRios commented May 6, 2024

@JuaniRios JuaniRios force-pushed the 05-06-remove_optional_mins_on_ticket_sizes branch from 259e190 to 2e81ab8 Compare May 6, 2024 10:04
@JuaniRios JuaniRios force-pushed the 05-03-try_out_assethub_transfers_with_chopsticks branch from 34249b1 to b2a40cc Compare May 6, 2024 11:04
@JuaniRios JuaniRios force-pushed the 05-06-remove_optional_mins_on_ticket_sizes branch 2 times, most recently from 8011afd to 4c0d796 Compare May 6, 2024 11:11
@JuaniRios JuaniRios marked this pull request as ready for review May 6, 2024 11:14
Copy link

graphite-app bot commented May 6, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/06/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 05-03-try_out_assethub_transfers_with_chopsticks branch from b2a40cc to 871496b Compare May 6, 2024 12:17
@JuaniRios JuaniRios force-pushed the 05-06-remove_optional_mins_on_ticket_sizes branch from 4c0d796 to 0a1dff1 Compare May 6, 2024 12:17
@JuaniRios JuaniRios force-pushed the 05-03-try_out_assethub_transfers_with_chopsticks branch from 871496b to d2d7675 Compare May 6, 2024 13:17
@JuaniRios JuaniRios requested review from lrazovic and vstam1 May 6, 2024 13:17
@JuaniRios JuaniRios force-pushed the 05-06-remove_optional_mins_on_ticket_sizes branch from 0a1dff1 to 7629181 Compare May 6, 2024 13:17
@JuaniRios JuaniRios force-pushed the 05-03-try_out_assethub_transfers_with_chopsticks branch from d2d7675 to 211d067 Compare May 6, 2024 13:37
@JuaniRios JuaniRios force-pushed the 05-06-remove_optional_mins_on_ticket_sizes branch from 7629181 to a5b055a Compare May 6, 2024 13:37
@JuaniRios JuaniRios force-pushed the 05-03-try_out_assethub_transfers_with_chopsticks branch from 211d067 to 0d78c8f Compare May 6, 2024 13:40
@JuaniRios JuaniRios force-pushed the 05-06-remove_optional_mins_on_ticket_sizes branch from a5b055a to 9a6ccab Compare May 6, 2024 13:40
Base automatically changed from 05-03-try_out_assethub_transfers_with_chopsticks to main May 6, 2024 13:41
Copy link
Contributor Author

JuaniRios commented May 6, 2024

Merge activity

  • May 6, 9:41 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • May 6, 9:42 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 6, 9:43 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios force-pushed the 05-06-remove_optional_mins_on_ticket_sizes branch from 9a6ccab to 111551e Compare May 6, 2024 13:42
@JuaniRios JuaniRios merged commit 010cfee into main May 6, 2024
@JuaniRios JuaniRios deleted the 05-06-remove_optional_mins_on_ticket_sizes branch May 6, 2024 13:43
JuaniRios added a commit that referenced this pull request May 6, 2024
## What?
- Fixes all the existing tests from #283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants