Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Payout funding assets to destination account #294

Merged
merged 1 commit into from
May 14, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented May 13, 2024

What?

  • Change account for the payout of funding assets to funding destination account instead of issuer account.

Why?

  • We weren't using the funding destination account as intended

How?

  • on the settle successful bid and successful contribution functions, change the payout account

Testing?

  • Added a new instantiator function assert_total_funding_paid_out which is now used on the settlement test can_settle_accepted_project

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios requested review from lrazovic and vstam1 May 13, 2024 12:03
@JuaniRios JuaniRios added the bug Something isn't working label May 13, 2024 — with Graphite App
@JuaniRios JuaniRios force-pushed the 05-13-payout_funding_assets_to_destination_account branch from 738db06 to 472f3fe Compare May 13, 2024 12:52
@JuaniRios JuaniRios marked this pull request as ready for review May 13, 2024 13:01
Copy link

graphite-app bot commented May 13, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/13/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 05-13-payout_funding_assets_to_destination_account branch from 472f3fe to 1716d11 Compare May 13, 2024 14:49
@JuaniRios JuaniRios changed the title Payout funding assets to destination account 🐛 Payout funding assets to destination account May 13, 2024
@JuaniRios JuaniRios merged commit 60e2eeb into main May 14, 2024
@JuaniRios JuaniRios deleted the 05-13-payout_funding_assets_to_destination_account branch May 14, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants