Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Change XCM execution fee destination to treasury #323

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jun 13, 2024

What?

  • When buying execution with the XCM instructionBuyExecution, make the amount spent go to the treasury instead of being burnt

Why?

💸

How?

  • Modify the traders assigned to XcmConfig::Trader
  • Put another custom generic inside FixedRateOfFungible and UsingComponents which sends to treasury instead of burning

Testing?

In integration tests, xcm_config::execution_fees_go_to_treasury

Copy link
Contributor Author

JuaniRios commented Jun 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios changed the title Fix xcm execution fee destinations 🔧 Change XCM execution fee destination to treasury Jun 13, 2024
@JuaniRios JuaniRios force-pushed the 06-13-fix_xcm_execution_fee_destinations branch from dcd2502 to 683a1f6 Compare June 14, 2024 10:40
@JuaniRios JuaniRios self-assigned this Jun 14, 2024
@JuaniRios JuaniRios marked this pull request as ready for review June 14, 2024 10:44
runtimes/polimec/src/xcm_config.rs Outdated Show resolved Hide resolved
runtimes/polimec/src/xcm_config.rs Outdated Show resolved Hide resolved
runtimes/polimec/src/lib.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/xcm_config.rs Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 06-13-fix_xcm_execution_fee_destinations branch 3 times, most recently from 8c04c69 to 3c1681d Compare June 14, 2024 12:31
@JuaniRios JuaniRios requested a review from vstam1 June 14, 2024 12:31
@JuaniRios JuaniRios force-pushed the 06-13-fix_xcm_execution_fee_destinations branch from 3c1681d to 27e6b72 Compare June 14, 2024 12:47
runtimes/polimec/src/xcm_config.rs Outdated Show resolved Hide resolved
runtimes/polimec/src/lib.rs Outdated Show resolved Hide resolved
runtimes/polimec/src/lib.rs Outdated Show resolved Hide resolved
runtimes/polimec/src/lib.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 06-13-fix_xcm_execution_fee_destinations branch 2 times, most recently from 2cffa21 to db91167 Compare June 14, 2024 13:02
@JuaniRios JuaniRios force-pushed the 06-13-fix_xcm_execution_fee_destinations branch from db91167 to afbc12c Compare June 14, 2024 13:49
@JuaniRios JuaniRios merged commit 0842df3 into main Jun 14, 2024
@JuaniRios JuaniRios deleted the 06-13-fix_xcm_execution_fee_destinations branch June 14, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants