Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📄 Small comment about Y variable #356

Merged
merged 1 commit into from
Jul 18, 2024
Merged

📄 Small comment about Y variable #356

merged 1 commit into from
Jul 18, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 9, 2024 •
edited
Loading

What?

  • Add comment to Y variable calculation to avoid confusion.

Why?

  • There was confusion that the Y variable could become higher than 1 when the funding amount reached was higher than the target funding (USD). This is not possible because Perquintill saturates to 1, but if we don't add a comment it might appear unintented.

How?

  • 2 identical comments on the Y calculations in generate_evaluator_rewards_info and generate_liquidity_pools_and_long_term_holder_rewards

@JuaniRios Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios changed the title Small comment about Y variable 📄 Small comment about Y variable Jul 9, 2024
@JuaniRios JuaniRios requested review from lrazovic and vstam1 July 9, 2024 14:09
@JuaniRios JuaniRios assigned JuaniRios and unassigned lrazovic and vstam1 Jul 9, 2024
@JuaniRios JuaniRios marked this pull request as ready for review July 9, 2024 14:09
@JuaniRios JuaniRios force-pushed the 07-09-small_comment_about_y_variable branch from cb302b3 to b284076 Compare July 9, 2024 14:11
@JuaniRios JuaniRios requested a review from vstam1 July 9, 2024 14:11
@JuaniRios JuaniRios force-pushed the 07-09-small_comment_about_y_variable branch from b284076 to 4efb057 Compare July 9, 2024 14:12
@JuaniRios JuaniRios merged commit f120272 into main Jul 18, 2024
@JuaniRios JuaniRios deleted the 07-09-small_comment_about_y_variable branch July 18, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@lrazovic lrazovic Awaiting requested review from lrazovic

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @vstam1 @lrazovic