Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve acccessibility of icons #160

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/templates/pages/contributors/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
{{/if}}
{{#if website}}
<p class="mt-1">
<i class="mr-1 text-gray-600 fas fa-sm fa-globe"></i>
<i class="mr-1 text-gray-600 fas fa-sm fa-globe" title="Website"></i>
{{#with (urlParse website)}}
<a href="{{../website}}" class="no-underline" {{#if (eq ../role "contributor")}}rel="nofollow noopener"
{{/if}}>{{ellipsis host 16}}&nearr;</a>
Expand All @@ -37,14 +37,14 @@
{{/if}}
{{#if github}}
<p class="mt-1">
<i class="mr-1 text-gray-600 fab fa-sm fa-github"></i>
<i class="mr-1 text-gray-600 fab fa-sm fa-github" title="GitHub"></i>
<a href="https://github.com/{{github}}" rel="nofollow noopener"
class="no-underline">{{ellipsis github 16}}&nearr;</a>
</p>
{{/if}}
{{#if email}}
<p class="mt-1">
<i class="mr-1 text-gray-600 fas fa-sm fa-envelope"></i>
<i class="mr-1 text-gray-600 fas fa-sm fa-envelope" title="Email"></i>
<a href="mailto:{{email}}" class="no-underline">{{ellipsis email 16}}&nearr;</a>
</p>
{{/if}}
Expand All @@ -54,4 +54,4 @@
</div>
</main>
{{/inline}}
{{/layouts/base}}
{{/layouts/base}}