Cross Chain Helper and THEA Withdrawal fix #262
Conversation
🦋 Changeset detectedLatest commit: 7e435fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate Limit Exceeded@ap211unitech has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 51 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates across various classes in the SDK introduce a new method Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (11)
- packages/thea/src/sdk/evm/sepolia.ts (1 hunks)
- packages/thea/src/sdk/substrate/assetHub.ts (1 hunks)
- packages/thea/src/sdk/substrate/astar.ts (1 hunks)
- packages/thea/src/sdk/substrate/bifrost.ts (1 hunks)
- packages/thea/src/sdk/substrate/interlay.ts (1 hunks)
- packages/thea/src/sdk/substrate/moonbeam.ts (1 hunks)
- packages/thea/src/sdk/substrate/phala.ts (1 hunks)
- packages/thea/src/sdk/substrate/polkadex.ts (1 hunks)
- packages/thea/src/sdk/substrate/polkadot.ts (1 hunks)
- packages/thea/src/sdk/substrate/unique.ts (1 hunks)
- packages/thea/src/sdk/types.ts (1 hunks)
Additional comments not posted (11)
packages/thea/src/sdk/types.ts (1)
26-28: The addition ofgetAllAssetsmethod to theBaseChainAdapterinterface is a good enhancement for standardizing asset retrieval across different chain adapters.packages/thea/src/sdk/substrate/interlay.ts (1)
41-45: The implementation ofgetAllAssetsin theInterlayclass correctly utilizeschangeSubstrateToBaseAssetto map substrate assets to the base asset format, enhancing the SDK's functionality.packages/thea/src/sdk/substrate/bifrost.ts (1)
41-45: The implementation ofgetAllAssetsin theBifrostclass correctly utilizeschangeSubstrateToBaseAssetto map substrate assets to the base asset format, enhancing the SDK's functionality.packages/thea/src/sdk/substrate/astar.ts (1)
41-45: The implementation ofgetAllAssetsin theAstarclass correctly utilizeschangeSubstrateToBaseAssetto map substrate assets to the base asset format, enhancing the SDK's functionality.packages/thea/src/sdk/substrate/phala.ts (1)
41-45: The implementation ofgetAllAssetsin thePhalaclass correctly utilizeschangeSubstrateToBaseAssetto map substrate assets to the base asset format, enhancing the SDK's functionality.packages/thea/src/sdk/substrate/unique.ts (1)
41-45: The implementation ofgetAllAssetsin theUniqueclass correctly utilizeschangeSubstrateToBaseAssetto map substrate assets to the base asset format, enhancing the SDK's functionality.packages/thea/src/sdk/substrate/assetHub.ts (1)
41-45: The implementation ofgetAllAssetsmethod looks correct and aligns with the PR objectives.Consider checking the performance if
assetsDatacontains a large number of assets, as mapping over them could be computationally expensive.packages/thea/src/sdk/substrate/moonbeam.ts (1)
41-45: The implementation ofgetAllAssetsmethod inMoonbeamclass is correct and consistent with the PR objectives.Consider evaluating the performance if
assetsDatacontains a large number of assets, as mapping over them could be computationally expensive.packages/thea/src/sdk/substrate/polkadot.ts (1)
41-45: The implementation ofgetAllAssetsmethod inPolkadotclass is correct and aligns with the PR objectives.Consider evaluating the performance if
assetsDatacontains a large number of assets, as mapping over them could be computationally expensive.packages/thea/src/sdk/substrate/polkadex.ts (1)
41-45: The implementation ofgetAllAssetsmethod inPolkadexclass is correct and consistent with the PR objectives.Consider evaluating the performance if
assetsDatacontains a large number of assets, as mapping over them could be computationally expensive.packages/thea/src/sdk/evm/sepolia.ts (1)
41-43: The implementation ofgetAllAssetsmethod inSepoliaclass is correct and aligns with the PR objectives.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lockis excluded by!**/*.lock
Files selected for processing (1)
- apps/web/.gitignore (1 hunks)
Files skipped from review due to trivial changes (1)
- apps/web/.gitignore
Description
In this PR, we will be going to add these changes -
In current interface for cross chain transfer, we are lagging a helper function for getting all supported assets for a chain. Basically, we need to have a function
getAllAssetsfor each chain. It's a must have function as Orderbook is using it frequently.Polkadex to other chain transfer i.e. THEA withdrawal is failing as there is a change in extrinsic. We will be making change to it accordingly to match backend requirements.
Summary by CodeRabbit
getAllAssets()method to various blockchain classes (Sepolia, AssetHub, Astar, Bifrost, Interlay, Moonbeam, Phala, Polkadex, Polkadot, Unique) to retrieve and map all assets.BaseChainAdapterinterface with the newgetAllAssets()method for unified asset retrieval.These changes provide a consistent way to access and manage all assets across different blockchain implementations, improving the user experience by simplifying asset management.