Withdraw to Relay chain Fix

[ap211unitech]

Description

Multilocation for Withdraw Relay chain

Summary by CodeRabbit

• Bug Fixes
  • Improved withdrawal functionality by handling cases where parachainId is -1, ensuring smoother transactions on the Relay chain.

[changeset-bot]

🦋 Changeset detected

Latest commit: ab62d1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@polkadex/thea	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This update refines the getDirectWithdrawalMultilocation function in the @polkadex/thea module. The key change is the addition of a condition to handle cases where parachainId is -1, enhancing the reliability of direct withdrawals to the Relay chain. This adjustment ensures the function behaves correctly in scenarios where the parachainId is unset or explicitly set to -1.

Changes

File	Change Summary
packages/thea/src/sdk/helpers.ts	Added a condition to check if parachainId is -1 in the getDirectWithdrawalMultilocation function.

Poem

In the land of code, a chain so grand,
Where parachains weave, and values stand,
We fixed a quirk, a minor plight,
Now withdrawals flow, just right,
With -1 in sight, no fear will stand,
Polkadex thrives, across the land.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a1dcf95 and 792807a.

Files selected for processing (2)

• .changeset/shiny-lions-give.md (1 hunks)
• packages/thea/src/sdk/helpers.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• .changeset/shiny-lions-give.md

Additional comments not posted (1)

packages/thea/src/sdk/helpers.ts (1)

67-67: Ensure correct handling of special cases in chain IDs.

The addition of parachainId === -1 to the condition checks for a special case where the parachainId might be intentionally set to -1 to indicate a specific scenario (likely a fallback or default case). This change improves the robustness of the function by ensuring that such cases are handled explicitly.

Ensure that the value -1 is a documented and agreed-upon value for indicating such scenarios and is not just an arbitrary choice. If -1 has a specific significance, it would be beneficial to add a comment explaining this for future maintainers.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 792807a and ab62d1a.

Files selected for processing (1)

• packages/thea/src/sdk/helpers.ts (4 hunks)

Files skipped from review as they are similar to previous changes (1)

• packages/thea/src/sdk/helpers.ts