substrate module @ pba3 #707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent into kiz-substrate-pba3
…tent into kiz-substrate-pba3
nuke-web3
reviewed
Jul 12, 2023
nuke-web3
reviewed
Jul 12, 2023
wirednkod
approved these changes
Jul 12, 2023
…cademy/pba-content into kiz-substrate-pba3
Co-authored-by: Nikos Kontakis <wirednkod@gmail.com>
…tent into kiz-substrate-pba3
Comment on lines
+6
to
+9
| /// Use manual seal, which basically produces blocks at fixed intervals, at the given interval. | ||
| /// | ||
| /// Example: `manual-seal-3000` will produce a block every 3 seconds. | ||
| ManualSeal(u64), |
There was a problem hiding this comment.
I think, "manual seal" usually refers to when you wire this thing up to the RPC and users manually author blocks by sending rpc commands to do so. Calling this interval seal might make more sense.
There was a problem hiding this comment.
good point, it is using manual-seal under the hood, but I have indeed created my own background task to manually trigger it every x milliseconds.
|
I seem to have messed up and causes some unneeded conflicts, will start from scratch in a fresh branch. |
|
@kianenigma not you - just the folder go renamed to account for module reordering - should be OK to reopen - just make tou working dir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #620 and in general preps substrate module for pba3.