substrate module @ pba3 #749
Conversation
| }) | ||
| let (signer, tip, nonce) = Self::solution_validate_transaction_inner(&ext)?; | ||
| let provides = vec![(signer.clone(), nonce).encode()]; | ||
| let requires = vec![(signer.clone(), nonce.saturating_sub(1)).encode()]; |
There was a problem hiding this comment.
I think this is slightly wrong, probably because I explained it too hastily. Please verify for yourself.
The requires tags should include all the transactions and only those transactions that we are still waiting to see at the time of validation. So if you find that the stored nonce is already one lower than the current tx, then add no requires tags.
But if you find that the stored nonce is three below the current tx, then you need two requires tags. (for nonce - 1 and nonce - 2).
| @@ -1,80 +1,8 @@ | |||
| # Substrate Frameless Node Template | |||
| # Framelss Activity V3 | |||
There was a problem hiding this comment.
#718 not gonna happen in this PR I guess? We can do latter, I see https://github.com/Polkadot-Blockchain-Academy/PBA3-frameless-node-template perhaps we can rm this code then?
| rustup target add wasm32-wasi | ||
| rustup target add wasm32-unknown-unknown | ||
|
|
||
| cargo init --lib | ||
| apply stuff (`cdylib`, `#[no_mangle]`) |
There was a problem hiding this comment.
is this file just internal facing scratch pad for you? if needed to run the module or needed to be shared with students, a touch of polish here to define how to use it for other instructors is needed ( can be a follow up PR)
closes #620 and in general preps substrate module for pba3.