Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds command token for arguments. #568

Merged
merged 10 commits into from
Oct 9, 2023
Merged

Adds command token for arguments. #568

merged 10 commits into from
Oct 9, 2023

Conversation

boehmseb
Copy link
Collaborator

@boehmseb boehmseb commented Oct 7, 2023

No description provided.

@boehmseb boehmseb requested a review from vulder October 7, 2023 18:06
@vulder vulder requested a review from simbuerg October 7, 2023 18:07
vulder
vulder reviewed Oct 8, 2023
View reviewed changes
benchbuild/command.py Outdated Show resolved Hide resolved
vulder
vulder approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the one broken test needs to be fixed but afterwards, we can merge this.

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (e2f829b) 49.49% compared to head (7280c24) 52.53%.

❗ Current head 7280c24 differs from pull request most recent head bad9f85. Consider uploading reports for the commit bad9f85 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
+ Coverage   49.49%   52.53%   +3.03%     
==========================================
  Files         120      120              
  Lines        8293     8318      +25     
  Branches     1060     1064       +4     
==========================================
+ Hits         4105     4370     +265     
+ Misses       4012     3763     -249     
- Partials      176      185       +9
Files Coverage Δ
benchbuild/command.py 53.90% <55.17%> (+0.15%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boehmseb boehmseb marked this pull request as ready for review October 9, 2023 08:39
simbuerg
simbuerg approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@simbuerg simbuerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@simbuerg simbuerg merged commit 745eefd into PolyJIT:master Oct 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simbuerg simbuerg simbuerg approved these changes

@vulder vulder vulder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boehmseb @simbuerg @vulder