Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace windows with windows-sys #118

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Replace windows with windows-sys #118

merged 3 commits into from
Apr 26, 2023

Conversation

Jake-Shadle
Copy link
Contributor

@Jake-Shadle Jake-Shadle commented Apr 13, 2023 •
edited
Loading

The windows crate is massive overkill for the features needed by this crate, so this PR replaces it with just windows-sys and adds the minimal COM bindings used by this crate. This also updates from 0.44 to 0.48, which is the current latest version of windows/-sys

  • Crate download: ~12MiB -> ~2.5MiB
  • Untarred source: ~171MiB -> ~30MiB
  • Build (debug): ~6.5s(1.0s codegen) -> ~1.1s
  • Build (release): ~7.5s(2.5s codegen) -> ~1.17s

Jake-Shadle
Jake-Shadle commented Apr 13, 2023
View reviewed changes
.github/workflows/rust.yml Show resolved Hide resolved
.github/workflows/rust.yml Show resolved Hide resolved
build.rs Show resolved Hide resolved
src/backend/win_cid/file_dialog.rs Show resolved Hide resolved
src/backend/win_cid/file_dialog/dialog_ffi.rs Show resolved Hide resolved
src/backend/win_cid/message_dialog.rs Show resolved Hide resolved
src/backend/win_cid/message_dialog.rs Show resolved Hide resolved
src/backend/win_cid/message_dialog.rs Show resolved Hide resolved
src/backend/win_cid/file_dialog/dialog_ffi.rs Outdated Show resolved Hide resolved
@Jake-Shadle Jake-Shadle mentioned this pull request Apr 13, 2023
Open
26 tasks
@Jake-Shadle Jake-Shadle mentioned this pull request Apr 20, 2023
Closed
PolyMeilex
PolyMeilex requested changes Apr 25, 2023
View reviewed changes
src/backend/win_cid/file_dialog.rs Show resolved Hide resolved
src/backend/win_cid/file_dialog/dialog_ffi.rs Outdated Show resolved Hide resolved
src/backend/win_cid/file_dialog/dialog_ffi.rs Outdated Show resolved Hide resolved
src/backend/win_cid/file_dialog/dialog_ffi.rs Show resolved Hide resolved
@PolyMeilex PolyMeilex merged commit 6168ea6 into PolyMeilex:master Apr 26, 2023
@PolyMeilex
Copy link
Owner

Thanks!

@repi repi mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PolyMeilex PolyMeilex PolyMeilex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jake-Shadle @PolyMeilex