-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#128 fix #129
base: master
Are you sure you want to change the base?
#128 fix #129
Conversation
That's a cool idea, but I'm pretty sure the supplied code does not work, the future will resolve immediately after click event and return None. This could be possible with Chrome specific File System Access API, but that's a more complex to implement, and I'm not sure if it's worth implementing if it can not replace HTML code any time soon if ever (file system access is a controversial spec). |
@PolyMeilex sorry i havent checked the ouput and you are right the event triggers as soon as it is pressed, but i dont know why. i tried out the events with plain html and it works like it is supposed to. |
@PolyMeilex i moved the eventlistener after the html is attached so the event wont be triggered immediately. Now it will only be triggered when a file is selected. I will look into it if there is an event that would be better suited than onchange. |
Even if you fix that, what's your plan for handling dialog cancelation? It does not trigger onChange as far as I remember |
@PolyMeilex chrome and safari focus the last focued element on close. Im looking into it how it could be deteted in firefox. alternativly it could be an option that it auto closes when a file is submitted and auto opens, but still display the popup as a fallback in case it is cancled. |
This doesn't appear to be Chrome specific. Can you share why it's controversial? |
#128 fix