-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze Minting #224
Freeze Minting #224
Conversation
What's the reasoning behind putting the Polymath allowFreezeMinting switch in the ModuleRegistry? Not that any of the other registries make more sense, though. |
@pabloruiz55 The reason for putting the feature switch in the MR is because it is the only registry with a link to the deployed ST since they communicate for module deployment. WRT a new feature switch contract, it seems like a bit of an overkill and would create additional dependencies. I am still not familiar with the new upgradability pattern so not sure what will be the implications. Maybe @adamdossa has more thoughts. |
@thegostep WRT where this switch goes, let's keep it simple for now:
|
Requirements
Changes
ISecurityToken.sol
finishMintingIssuer()
and functionfinishMintingSTO()
freezeMinting()
SecurityToken.sol
freeze
to booltransfersFrozen
mintingFrozen
finishedIssuerMinting
and boolfinishedSTOMinting
LogFinishMintingSTO
and eventLogFinishMintingIssuer
LogFreezeMinting
finishMintingIssuer()
and functionfinishMintingSTO()
freezeMinting()
isMintingAllowed
to only check formintingFrozen
onlyModule()
to remove fallback ononlyOwner
onlyModuleOrOwner()
create IFeatureRegisty.sol
create FeatureRegisty.sol
RegistryUpdater.sol
featureRegistry