-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DAI to USDTieredSTO #271
Conversation
adamdossa
commented
Sep 19, 2018
•
edited
Loading
edited
- Added DAI as an accepted currency for USDTieredSTO
- Added daiToken as configuration param to USDTieredSTO
- Updated tests including USDTieredSTO Sim
- Updated CLI to reference new functions
@adamdossa PR Looks good to me when all the test cases get passed then I will approve it. |
@VictorVicente I made updates to the CLI for the new functions, but I think accepting DAI for USDTieredSTO's will need more changes. We will need to decide what to do on ganache / testnet for DAI (probably easiest is to generate a mocked token, or re-use polyToken (current approach). |
@satyamakgec Test cases all run to success - please review. |