-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better redemption mechanics #291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdossa
changed the title
Add better redemption mechanics
WIP: Add better redemption mechanics
Sep 28, 2018
adamdossa
changed the title
WIP: Add better redemption mechanics
Add better redemption mechanics
Sep 30, 2018
satyamakgec
suggested changes
Oct 1, 2018
satyamakgec
approved these changes
Oct 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @pabloruiz55 please take a second look
pabloruiz55
reviewed
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redemption Mechanics:
NB - redemption / burning is the same thing - currently we use burn rather than redeem as the verb.
Currently we have a burn function that references a ITokenBurner contract that can only be called by the user wishing to burn tokens.
Issues:
approve
someone to burn tokens on your behalfRequirements:
Implementation:
burnFrom
as an analogue oftransferFrom
- i.e. uses allowance to burn tokens on behalf of someone elseburn
andburnFrom
can only be called from a REDEMPTION type moduleforceBurn
to allow an issuer to burn someone elses tokens (subject to same controls asforceTransfer
burn
orburnFrom
(i.e. we useonlyModule
, notonlyModuleOrOwner
)tokenBurner
as redemption logic will instead happen in REDEMPTION moduleNotes: