Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace squatting in MR #297

Merged
merged 9 commits into from
Oct 2, 2018

Conversation

adamdossa
Copy link
Contributor

@adamdossa adamdossa commented Oct 1, 2018

  1. You need to be owner to register (and verify) modules until customModulesAllowed is switched on in the feature registry.

  2. Cleaned getters for MR - we now have:

    function getTagsByTypeAndToken(uint8 _moduleType, address _securityToken) external view returns(bytes32[], address[]);
    function getTagsByType(uint8 _moduleType) external view returns(bytes32[], address[]);
    function getModulesByType(uint8 _moduleType) external view returns(address[]);
    function getModulesByTypeAndToken(uint8 _moduleType, address _securityToken) external view returns (address[]);

  1. Removed - tags looked up directly in module factories:
    addTagsByModuleType
    removeTagsByModuleType

@pabloruiz55
Copy link
Contributor

Looks good now, @satyamakgec please review and approve if everything looks ok.

@satyamakgec satyamakgec merged commit e871913 into development-1.5.0 Oct 2, 2018
@adamdossa adamdossa deleted the fix_namespace_squatting_in_MR branch October 2, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants