-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dividend name #299
Dividend name #299
Conversation
@maxsam4 Looks good to me - only comment is please could the function: |
Renamed `_CallERC20DividendDepositedEvent` to `_emitERC20DividendDepositedEvent`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a big fan of bytes32
but if we can replace the datatype to bytes32 for name
then we can indexed
it in the events that may useful for the dApp team.
looks good! Needs @satyamakgec 's approval |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Enhancement
What is the current behavior?
Dividends are unnamed
What is the new behavior?
Dividend have a name
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Need to pass Dividend name when creating a Dividend.
Any Other information:
Fixes #295