Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ganache limit changed to 8mm for tests #300

Merged
merged 5 commits into from
Oct 2, 2018
Merged

Conversation

pabloruiz55
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our Submission guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)

What is the current behavior?

(You can also link to an open issue here)

What is the new behavior?

(Define and describe any new functionality. Clarify if this is a feature change)

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

Any Other information:

@maxsam4
Copy link
Contributor

maxsam4 commented Oct 2, 2018

Removed hard coded gas amounts that were above 80 million otherwise tests will fail due block gas limit not being sufficient.

@satyamakgec satyamakgec merged commit bd35cc9 into development-1.5.0 Oct 2, 2018
@maxsam4 maxsam4 deleted the ganache-limit branch October 10, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants