Permission manager changes #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyamakgec
suggested changes
Oct 4, 2018
contracts/modules/PermissionManager/GeneralPermissionManager.sol
Outdated
Show resolved
Hide resolved
contracts/modules/PermissionManager/GeneralPermissionManager.sol
Outdated
Show resolved
Hide resolved
contracts/modules/PermissionManager/GeneralPermissionManager.sol
Outdated
Show resolved
Hide resolved
contracts/modules/PermissionManager/GeneralPermissionManager.sol
Outdated
Show resolved
Hide resolved
contracts/modules/PermissionManager/GeneralPermissionManager.sol
Outdated
Show resolved
Hide resolved
contracts/modules/PermissionManager/GeneralPermissionManager.sol
Outdated
Show resolved
Hide resolved
contracts/modules/PermissionManager/GeneralPermissionManager.sol
Outdated
Show resolved
Hide resolved
|
@comeonbuddy please review the PR as tests seem not to be passing. |
|
all test now fixed, pls have a look again. |
pabloruiz55
reviewed
Oct 4, 2018
| require(_multiModules.length == _multiPerms.length, "modules and permission length are not same"); | ||
|
|
||
| for(uint8 i=0;i<_multiPerms.length;i++){ | ||
| bool _currentPerm = !perms[_multiModules[i]][_delegate][_multiPerms[i]]; |
There was a problem hiding this comment.
instead of duplicating the logic, for each entry call changePermission @comeonbuddy
|
Hey @pabloruiz55 I am doing some improvements in the logic |
satyamakgec
approved these changes
Oct 4, 2018
adamdossa
suggested changes
Oct 4, 2018
contracts/modules/PermissionManager/GeneralPermissionManager.sol
Outdated
Show resolved
Hide resolved
…athNetwork/polymath-core into Permission-Manager-Changes
adamdossa
approved these changes
Oct 5, 2018
maxsam4
reviewed
Oct 5, 2018
| TRAVIS_PULL_REQUEST=false scripts/test.sh |
There was a problem hiding this comment.
This will disable coverage calculation on local machines but won't affect travis as travis sets TRAVIS_PULL_REQUEST to the pull request number automatically (which apparently, can't be overwritten).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
added 5 more functions in general permission manager
https://app.asana.com/0/843053006731091/818024811891878
Does this PR introduce a breaking change?
No.
Any Other information:
In getAllModulesAndPerms(), as discussed we will pass on the module types as input to the function.
Similarly in getAllDelegatesWithPerm(), assume module add will also be provided.
Uint test is working.