Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to yarn from npm #340

Merged
merged 5 commits into from
Oct 12, 2018
Merged

Migrating to yarn from npm #340

merged 5 commits into from
Oct 12, 2018

Conversation

maxsam4
Copy link
Contributor

@maxsam4 maxsam4 commented Oct 12, 2018

Please check if the PR fulfills these requirements

  • The commit message follows our Submission guidelines
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Migrating to yarn from npm

What is the current behavior?

A mixture of yarn and npm is used

What is the new behavior?

Strictly yarn is used for adding/removing packages. I have removed package-lock.json and updated yarn.lock.

Does this PR introduce a breaking change?

No.

Any Other information:

npm isn't working for new users. Hence we have decided to move to yarn instead.
If you prefer to use npm then you can continue using npm but please don't push the package-lock.json to the repo.
If you want to add a new node_module, then please use yarn add module instead of npm install module and push your yarn.lock only if it's clean.

@satyamakgec
Copy link
Contributor

@maxsam4 Please add package-lock.json in .gitignore. So if anyone wants to use it then they can on the local but it doesn't affect on the remote.

@pabloruiz55 pabloruiz55 merged commit 06a1916 into development-1.5.0 Oct 12, 2018
@maxsam4 maxsam4 deleted the yarn branch January 11, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants