New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Volume Lockup Transfer Manager #349

Closed

tanpv wants to merge 5 commits into PolymathNetwork:development-1.5.0 from tanpv:development-1.5.0

tanpv commented Oct 17, 2018

Please check if the PR fulfills these requirements

[DONE ] The commit message follows our Submission guidelines
[DONE] Tests for the changes have been added (for bug fixes / features)
[DONE ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Optimize for cleaner verifyTransfer algorithm

What is the current behavior?

Optimize algorithm for issue Module Development Task: Lockup Volume Restrictions #287
Reduce calculation in order to verify transfer

What is the new behavior?

Remove "alreadyWithdrawn" from "LockUp" struct
Add function "_getInvestorCurrentLockUpAmount"
Change logic inside "verifyTransfer"

Does this PR introduce a breaking change?

No breaking change
All tests are run passed

Any Other information:

tanpv added 5 commits

October 16, 2018 18:13


          change verify function

02cbdd9


          better naming

4c558fd


          modify naming and test for new name

67900e4


          rename test file

e9affe1


          Merge branch 'development-1.5.0' into development-1.5.0

ae1c493

tanpv changed the title ~~Development 1.5.0~~ Optimize Volume Lockup Transfer Manager

Contributor

satyamakgec commented Nov 15, 2018

Thanks, @tanpv for your work but we optimize in #409 PR

satyamakgec closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet