changed sto cap to tokens, added function for owner to mint his token… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdossa
reviewed
Mar 27, 2018
contracts/modules/STO/CappedSTO.sol
Outdated
| * wallet and issuer tokens were assigned on configuration and can't be modified | ||
| */ | ||
| function mintIssuerTokensToWallet() public onlyOwner { | ||
| uint tokensToMint = issuerTokens; |
There was a problem hiding this comment.
We should try and be explicit using uint256 instead of uint
adamdossa
reviewed
Mar 27, 2018
| @@ -293,29 +295,35 @@ async function step_STO_Launch(){ | |||
| await cappedSTO.methods.wallet().call({from: Issuer}, function(error, result){ | |||
| displayWallet = result; | |||
| }); | |||
| await cappedSTO.methods.issuerTokens().call({from: Issuer}, function(error, result){ | |||
There was a problem hiding this comment.
I don't think this is a call? It changes state, so needs to be submitted as a transaction,
There was a problem hiding this comment.
Ah - ignore this - you're just displaying the value here, not actually minting the tokens
There was a problem hiding this comment.
Yes, this is just to display how many tokens were assigned to the wallet
added 2 commits
March 27, 2018 13:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s once