Count tm audit change #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsam4
approved these changes
Nov 29, 2018
…time when it is already full.
…en max holder amount is full
adamdossa
approved these changes
Dec 4, 2018
maxsam4
reviewed
Dec 6, 2018
test/d_count_transfer_manager.js
Outdated
| // Mint some tokens | ||
| await I_SecurityToken2.mint(account_investor1, web3.utils.toWei("1", "ether"), { from: token_owner }); | ||
| await I_SecurityToken2.mint(account_investor2, web3.utils.toWei("1", "ether"), { from: token_owner }); | ||
|
|
There was a problem hiding this comment.
Missing mint statement for account_investor3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
update verifyTransfer according to Mudit's audit
https://app.asana.com/0/843053006731091/853001457736276
What is the current behavior?
doesnt allow adding new investors if deleting one at the same time.
What is the new behavior?
allows adding new investors if deleting one at the same time.
Does this PR introduce a breaking change?
no
Any Other information: