Fix rounding off errors #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The simulation ran out of DAI. That's new. |
adamdossa
approved these changes
Dec 14, 2018
adamdossa
added a commit
that referenced
this pull request
Dec 14, 2018
* Update n_security_token_registry.js * mainnet 2.0.0 registry address * mainnet addresses * Added internal nonce management * nonce tracking fixed * minNonce fixed * Nonce not BN * None init fixed * strMigrator mainnet fixes * Send function fixed * await Optimizations * Skip token deployment if the ST address is known * migrator fixes * Function modifier changes * Minimum investment logic change * Only tickers option * Possibility to skip tickers * Fix * removing CLI from README * Merge remote-tracking branch 'origin/dev-2.1.0' into CLI-st20generator-refactoring * Whitelist refactor * Updated documentation * minor fix * ignore the certificate * Allow unauthenticated repos * Removed travis before install * Configuration by factory allowed only once * Multi mint refactor * Accredit refactor * token_manager command * Non accredited limit refactor + delete old files and packages dependencies * sto_manager command * Support for indivisible tokens * bug fix * test cases for divible token capped STO * CSV sync & ST20generator fix * Updated CLI introduction and link to wiki * Add getTokensSoldByTier * Improvements over mint tokens (parseFloat for divisible tokens) * fixed issue with CLI and added more flattener commands * Update changelog * Typo * readme update * Final CSV refactor * Uploaded Solidified's 2.0.0 auditreport * replaced audit report for 2.0.0 * Added helper view functions * Updated gitignore * Bug fix * Updated changelog * Added test cases * Minor fix * CLI changes for new USDTieredSTO changes * Add transferOwnership to MR (#425) * Add transferOwnership to MR * New test case * added new MR/STR proxy addresses to readme * Typo fix Co-Authored-By: maxsam4 <guptamudit@ymail.com> * Allow 0x transfers for MATM * Fix typo * Add support to remote nodes * sto_manager improvements * Minor improvements * Get configure function from ABI * Flow changes * Skip emiting event when no tokens purchased * typo fix * dev-2.1.0 changes * General fixes * Minor fixes * Revert "STRV TM added to migration script" This reverts commit d7e97bb. * Update CHANGELOG.md * updated description for cappedSTO * fix test * Minor fix * MATM to master (#435) * Allow 0x transfers for MATM * Fix typo * changelog updated and MATM version changed * Update CHANGELOG.md * fixed MATM test w/ version change * Linter fixes * Optimise GTM (#433) - Add an Offset that can be used to move all from & to dates forwards or backwards by a fixed offset. - Add address[] public investors to record a list of all addresses that have been added to the whitelist - Fix for when allowAllWhitelistIssuances is FALSE - Clearer logic around toTime, fromTime & expiryTime - Make GTM a Proxy based implementation to reduce deployment gas costs * 2.0.1 MATM deployed to mainnet * Revert "Optimise GTM (#433)" (#436) This reverts commit 42e4a78. * Update README.md * MATM CLI support * TokenInfo scripts update * add new core 2.0.0 diagram to readme * Rate changed * changelog updated * Updated tests for rate changes * Issuance test fixed * test cases updated * resolve conflicts in changelog * resolve conflicts in readme * Update README.md * fixed link on readme * Minor fixes * minor fix in readme to reset the MATM * update readme.md Updated from introduction to core up until setting up polymath core * Updated comments * Allow to add TM modules from token_manager * Whitelist from csv fix * Deleted network variable * CLI - Fix at removing modules * CLI - Fix on exit at token selection * CLI - Support for not integer rates on CappedSTO * CLI - Minor fix * fixing audit change request from Mudit * Update script fetch correct solc version * moving multi mint to token manager * replace multi mint to token manager method in cli menu * moving accredit to sto manager file * moving accreditable and nonAccreditable to STO manager * Count transfer manager * Percentage transfer manager * Added docs generation to CI * Path fix * script fix * Testing travis * Testing travis * Testing travis * Testing travis * Testing travis * Testing travis * Testing travis * whitelist to transfer manager * added test cases for adding new holders and removing one at the same time when it is already full. * Update script fetch correct solc version * Added docs generation to CI * Path fix * script fix * Solved merge conflict * Testing travis * Testing travis * Testing travis * Testing travis * Testing travis * Testing travis * WIP * CSV parser * Data folder reorganization * Refactoring and improvements * STO manager refactoring for batch operations * Transfer manager refactoring for batches * Fix * Multi mint in batches * Fuzz test permissions manager module (#395) * count transfer manager module fuzz testfinished * fuzz test for general transfer manager * fuzz tests updates * permission manager fuzzer volumn restriction transfer manager * mint token err * minting issue * fixing some testsing issuesss * all done * fixed cleaning up and commenting of the fuzz test codes * fixed conflict and merged new development functions, deleted all code with STVRTM. * get rid of test for STVTM * adding back missing file * get rid of STVR test * Delete x_single_trade_volume_restriction.js * deleted unused code :( * modifyWhitelistMulti for PercentageTM * adjust test cases for adding and removing holders at the same time when max holder amount is full * Bump the version * adjust test logic * Optimise GTM (#443) * WIP * WIP * Fixes * Update config * Log gas for 50 txs * WIP * update * Fix tests * Fix typo * Change onWhitelist logic * Update changelog * Update all test cases * Add whitelist optimization * Make Dividend modules proxies * Updates * minor cleanup * make script dynamic * Keep ABI constant * Fixes * Update change log * Updates * add require statement in factory constructors * remove the test cases for the STVRTM * Return investor data in getAllInvestorsData * CLI changes according GTM optimizations * Bump versions * version changes * Update CHANGELOG.md * Merged conflicts with master on the CLI * Merge fix * change the type of proxy deployment for USDTieredSTO * Time travel on development network * Fix jump a period of time * bump the version * Show total investors and current percentage ownership at transfer * Modules available are read from ModuleRegistry * Removed sim and fuzz tests from coverage * Time traveling fixes * Add DateTimeLibrary * Error message * Skip DateTime library in code coverage * Update CHANGELOG.md * Update CHANGELOG.md * Fix rounding off errors (#467) * Fixed rounding off errors * Increased tolerance * Reduced tolerance to zero * Comment updated * Tolerance set to 2 * Remove unused contract * Fix test cases * Fix typo * More test fixes * Fix fuzz tests
adamdossa
added a commit
that referenced
this pull request
Jan 28, 2019
* Updated changelog * Changed currencyRaised to stableCoinsRaised * MATM contract and test fixes * minor fix * CLI - LockupTM support * individual balance for every stable coin listed * CLI minor fixes * recommended fixes * Added code comments * Removed uninitialized pointer * CLI - Fixes for new contract changes * Minor fix * trying by adding some buffer in time travel * [WIP] CLI advances * modify function changes * WIP * CircleCI changes * CircleCI changes * CircleCI changes * Badge * Store test results * Removed coverage from commit workflow * CLI - WIP VolumeRestrictionTM support * CLI - Removed STVR TM from CLI * Added test reporter * Addded artifact collection * Added parallelism * Comment * Bumped parallelism to 3 * Coverage requires approval * Bumped parallelism to 4 * Removed manual approval * Combine travis and CircleCI * env var changes * comment * Improve MATM to allow allowances and expiryTimes to be changed for existing approvals * Refactoring and improvements * CLI - Operations in batch for VRTM * fuzz test for adding and removing modules * finished module fuzz test * Fix rounding off errors (#467) * Fixed rounding off errors * Increased tolerance * Reduced tolerance to zero * Comment updated * Tolerance set to 2 * Minor CLI changes * fix modify batch * Increased no o/p timeout * Improve menu string * Triggering CircleCI * CLI minor changes * Add ability to see excluded addresses * Updates * Fixes * Bump excluded limit to 150 * remove SRVTM * Use investor list from checkpoint * CLI - Script to generate tokens, whitelist investors and mint to them * CLI - Explore account * Update PolyTokenFaucet.sol * Improved the natspec comments * added VestingEscrowWalletLogic to output * Track withheld at dividend granularity * wip - issue with test not finishing * removed redundant dependencies * increased versions * WIP-multiple transaction within 1 day with Individual and daily Restrictions * updated yarn.lock * Add balances & claim amounts to getters * CLI - Flow change and updates for dividends_manager * Updated test script * Script updated * fixed bug with the initial test * Update test.sh * Script updated * coverage block gas limit increased * ganache-cli 6.2.5 * Travis submit coverage * added scenario 2 and 3 * fix input random number issue * Add more test cases * CLI Minor fixes * 483 484 fix (#488) * Removed the Redundant functions from eternal storage contract as mentioned in Issue#483, Converted Internal functions to public ones as mentioned in #484 & there was a function named getArrayString, I have removed that function because it was returning Array of String, which is not possible as it isn't supported by Current ABIENCODER. * Removed the Redundant functions from eternal storage contract as mentioned in Issue#483, Converted Internal functions to public ones as mentioned in #484 & there was a function named getArrayString, I have removed that function because it was returning Array of String, which is not possible as it isn't supported by Current ABIENCODER. * Add getCheckpointData * CLI minor changes * CLI typo fix * bug fixes * CLI updates * finished test case 4 * repeat period count from the startTime * WIP * fixed functions getActiveApprovalsToUser and added getAllApprovals() both will return all approval details in multiple arrays as requested * edited function description * Bumped cappedSTO version * MATM version bumped * CLI update * test case fixed * Update j_manual_approval_transfer_manager.js * WIP * reinvent the test case * Merge conflicts * indexing the param (#500) * Permissions update * Removed redundant events * dual truffle coverage * VRTM coverage fix * Added compile command * Updated coverage script * removed compile command * Updated truffle config * Pull accredited lists from USDSTO (#502) * WIP * Add getter * Update changelog * Remove commented code * CLI - Show accredited data * Update contracts/modules/STO/USDTieredSTOStorage.sol Co-Authored-By: adamdossa <adam.dossa@gmail.com> * Remove commented code * add getRestrictedAddresses() function * minor fix * Fixed test file * Add restrictions data to getRestrictedAddresses * Remove commented code and better tests * modified the getRestrictedAddress() function * code cleanup * CLI - Show restrictions table * minor fix * CLI - Update method name, updated csv dates * Trigger TravisCI * CLI - Changed names of restrictions * Minor fix * CLI - Percentage with decimals fix * CLI - Changed names of restrictions * add exempt list getter * minor fix * CLI - Added 'show exempted addresses' * Small optimisation * compilation errors * compilation errors in modules * compilation errors * Move contracts to the respective folders (#510) * move storage contracts to storage folder and migrate vesting to experimental * BTM migrate to experimental * move Lockup to experimental * Small re-shuffling * remove _ prefix from public functions * removed polyToken from factories * Fix comments (#519) * Fix STR size * fixed b_capped_sto.js * capped_sto fix * Remove duped test cases * Fix erc20 test * More fixes * fixes for h_general_transfer_manager.js * fixes for h_general_transfer_manager.js * fixes for j_manual_approval_transfer_manager.js * fixed n_security_token_registry.js * h_general_transfer_manager.js -removed redundant block due to merge issue * fixes for u_module_registry_proxy.js * fixes for z_vesting_escrow_wallet.js * fixes for z_vesting_escrow_wallet.js * Dividend improvements (#526) * Working * Wallet change test case * Fix ether dividend tests * CLI - Update for wallet on dividends modules * Add estimated tax / amounts to getter * CLI - Update for dividends status data * Fix MATM test case * fixes for z_vesting_escrow_wallet.js * Update * Remove unnecessary import * Clean up some imports * Small size optimisation and migrate fix * fixes for z_vesting_escrow_wallet.js * fixes for z_vesting_escrow_wallet.js (finished) * fixes for y_volume_restriction_tm.js * fixes for y_volume_restriction_tm.js * Some struct refactoring. * Some more optimisations * Some more optimisations * Merge 2.1 fix * More optimisations * Remove comments * Fixed imports in tests * Some updates * Some updates * WIP fixes * Some more updates * Add temp.js * Updates * Updates * Fixes * Fixes * Updates * usdtsto optimization (#534) * Initial optimization * Tests fixed * comments removed * Make some functions external * Updates * More fixes * Fix circle-ci * Add more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (some of) the rounding errors.