Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency cleanup #557

Merged
merged 7 commits into from
Feb 19, 2019
Merged

Dependency cleanup #557

merged 7 commits into from
Feb 19, 2019

Conversation

maxsam4
Copy link
Contributor

@maxsam4 maxsam4 commented Feb 19, 2019

Dependency cleanup

@coveralls
Copy link

coveralls commented Feb 19, 2019

Coverage Status

Coverage remained the same at 96.046% when pulling 2613f60 on signed-data into 957b9e3 on dev-3.0.0.

@maxsam4 maxsam4 changed the title Signed data Dependency cleanup Feb 19, 2019
@@ -1,6 +1,6 @@
{
"name": "polymath-core",
"version": "2.0.0",
"version": "3.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the bump of the version during the release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already bumped 2.1 version. It helps the dApp guys. I am fine with any though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then leave as it is

@satyamakgec satyamakgec merged commit 3375bca into dev-3.0.0 Feb 19, 2019
@satyamakgec satyamakgec deleted the signed-data branch February 19, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants