Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows explicit token factory version in generateSecurityToken() #568

Merged
merged 11 commits into from
Mar 4, 2019
Merged

Allows explicit token factory version in generateSecurityToken() #568

merged 11 commits into from
Mar 4, 2019

Conversation

satyamakgec
Copy link
Contributor

No description provided.

@satyamakgec satyamakgec changed the title allows explicit token factory version in generateSecurityToken() WIP: allows explicit token factory version in generateSecurityToken() Feb 21, 2019
@satyamakgec satyamakgec changed the title WIP: allows explicit token factory version in generateSecurityToken() Allows explicit token factory version in generateSecurityToken() Feb 22, 2019
@coveralls
Copy link

coveralls commented Feb 22, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 95.947% when pulling c56fb1d on add-protocolVersion into 0b9e51d on dev-3.0.0.

maxsam4
maxsam4 reviewed Feb 28, 2019
View reviewed changes
Copy link
Contributor

@maxsam4 maxsam4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the STR interface as well.

contracts/SecurityTokenRegistry.sol Show resolved Hide resolved
contracts/SecurityTokenRegistry.sol Outdated Show resolved Hide resolved
contracts/SecurityTokenRegistry.sol Outdated Show resolved Hide resolved
adamdossa
adamdossa reviewed Feb 28, 2019
View reviewed changes
contracts/STRGetter.sol Outdated Show resolved Hide resolved
@adamdossa
Copy link
Contributor

@satyamakgec left a couple of minor comments.

@satyamakgec satyamakgec merged commit 92807d1 into dev-3.0.0 Mar 4, 2019
@satyamakgec satyamakgec deleted the add-protocolVersion branch October 30, 2019 12:22
This was referenced Mar 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdossa adamdossa adamdossa left review comments

@maxsam4 maxsam4 maxsam4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@satyamakgec @coveralls @adamdossa @maxsam4 @SatyamSB