VRTM audit fixes #617

satyamakgec · 2019-03-26T10:40:25Z

No description provided.

coveralls · 2019-03-27T05:24:33Z

Coverage increased (+0.5%) to 97.087% when pulling 8d87605 on vrtm-audit-fixes into 923926e on dev-2.1.0.

Need to re review the changes

contracts/libraries/VolumeRestrictionLib.sol

audit fixes 1..9

c4afe28

satyamakgec changed the title ~~VRTM audit fixes~~ [WIP]:VRTM audit fixes Mar 26, 2019

add test cases for the major issue

95e7b2c

satyamakgec changed the title ~~[WIP]:VRTM audit fixes~~ VRTM audit fixes Mar 26, 2019

satyamakgec requested a review from maxsam4 March 26, 2019 14:05

SatyamSB added 2 commits March 26, 2019 23:32

test fix

de6decc

improve the test run

1191f38

maxsam4 previously approved these changes Mar 27, 2019

View reviewed changes

SatyamSB added 2 commits March 28, 2019 16:58

add the startTime == 0 check

60b2aa0

resolve the edge case when the investors restriction changes

031f5dd

satyamakgec changed the title ~~VRTM audit fixes~~ [WIP]:VRTM audit fixes Mar 29, 2019

maxsam4 added 3 commits March 29, 2019 16:03

Minor change

3672305

VRTM size reduction to 24.21KB

6aba6b9

Reduced VRTM size to be under the limit

5a2231a

add the code comments

7309dcb

satyamakgec changed the title ~~[WIP]:VRTM audit fixes~~ VRTM audit fixes Mar 29, 2019

increase the time to fix the coverage

4c43cf5

maxsam4 reviewed Mar 29, 2019

View reviewed changes

contracts/libraries/VolumeRestrictionLib.sol Outdated Show resolved Hide resolved

optimize the code

8d87605

maxsam4 approved these changes Mar 29, 2019

View reviewed changes

satyamakgec merged commit bed595d into dev-2.1.0 Mar 29, 2019

satyamakgec deleted the vrtm-audit-fixes branch October 30, 2019 12:23

Provide feedback