-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 2.1.0 updates and updates for 3.0.0 #659
Merge 2.1.0 updates and updates for 3.0.0 #659
Conversation
This is great! Just let me know if you have any doubt. Once you think it's ready I'll test it if you want. |
@VictorVicente I just plan to do bits every now and again in my spare time so if you had this planned for anytime soon feel review and merge as is. It will be better than the current broken version at least 😄 The ST20 Generator and STM are working now if you wanted to check them in your own time. Next I planned to work on the Transfer manager, STO manager and Investor portal. I intended to just getting them working again rather than adding any 3.0.0 features specifically or doing any major changes to the code. |
@VictorVicente This should now be ready for your review |
Hey @F-OBrien, I see you have been busy last days! Excellent job! It's amazing what you've done. |
@VictorVicente There is still a lot missing. I mainly got everything working again but did add some functions. As there are a lot of changes in the pull request I didn't want to go adding too much additional until after it got merged. I see @satyamakgec is updating the interface files in PR 682 so once he has them updated they can be removed from this PR. If you've any questions or want me to make any changes let me know. Otherwise your free to work on these as you wish. |
I was just writing you to ask this merge. You are so fast 👍 |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Merge dev-2.1.0 CLI updates
fixes & updates to token and registry interface files
fixed ST20Generator and update for 3.0.0
fixed Token Manager and update for 3.0.0
What is the current behavior?
CLI is currently broken in dev-3.0.0
What is the new behavior?
some CLI's are now working
Does this PR introduce a breaking change?
No
Any Other information: