Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approved Audit fixes #705

Merged
merged 44 commits into from
Jun 14, 2019
Merged

Approved Audit fixes #705

merged 44 commits into from
Jun 14, 2019

Commits on May 27, 2019

  1. Add StatusCode library

    @SatyamSB
    SatyamSB committed May 27, 2019
    Configuration menu
    Copy the full SHA
    67b2ba0 View commit details
    Browse the repository at this point in the history

  2. make inline library

    @SatyamSB
    SatyamSB committed May 27, 2019
    Configuration menu
    Copy the full SHA
    125fc9d View commit details
    Browse the repository at this point in the history

  3. remove the helpers/PolyToken.sol

    @SatyamSB
    SatyamSB committed May 27, 2019
    Configuration menu
    Copy the full SHA
    3bc7cf7 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2019

  1. Merge pull request #692 from PolymathNetwork/task_3.28 

    Remove helpers/PolyToken.sol
    @maxsam4
    maxsam4 authored May 31, 2019
    Configuration menu
    Copy the full SHA
    6322b72 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #690 from PolymathNetwork/task_3.17 

    Add StatusCode library
    @maxsam4
    maxsam4 authored May 31, 2019
    Configuration menu
    Copy the full SHA
    92c12c0 View commit details
    Browse the repository at this point in the history

  3. remove the IBoot from the contracts (#687)

    @satyamakgec @maxsam4
    satyamakgec authored and maxsam4 committed May 31, 2019
    Configuration menu
    Copy the full SHA
    7c8fe9f View commit details
    Browse the repository at this point in the history

  4. cleanup (#686)

    @satyamakgec @maxsam4
    satyamakgec authored and maxsam4 committed May 31, 2019
    Configuration menu
    Copy the full SHA
    66879f5 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary modifiers (#685)

    @satyamakgec @maxsam4
    satyamakgec authored and maxsam4 committed May 31, 2019
    Configuration menu
    Copy the full SHA
    d30f114 View commit details
    Browse the repository at this point in the history

  6. Remove KindMath from TokenLib (#684) 

    * cleanup

* remove the KindMath
    @satyamakgec @maxsam4
    satyamakgec authored and maxsam4 committed May 31, 2019
    Configuration menu
    Copy the full SHA
    25219c9 View commit details
    Browse the repository at this point in the history

  7. Marked some functions as external (#678)

    @maxsam4
    maxsam4 authored May 31, 2019
    Configuration menu
    Copy the full SHA
    073683d View commit details
    Browse the repository at this point in the history

  8. Removed redundant pause/unpause (#676)

    @maxsam4
    maxsam4 authored May 31, 2019
    Configuration menu
    Copy the full SHA
    f307619 View commit details
    Browse the repository at this point in the history

  9. Made onlyModuleOrOwner definition consisitent (#674) 

    * Made onlyModuleOrOwner definition consisitent

* Added braces

* Added braces
    @maxsam4
    maxsam4 authored May 31, 2019
    Configuration menu
    Copy the full SHA
    77e68d0 View commit details
    Browse the repository at this point in the history

  10. minor undeflow fix in vesting ewallet (#673)

    @maxsam4
    maxsam4 authored May 31, 2019
    Configuration menu
    Copy the full SHA
    dce8c41 View commit details
    Browse the repository at this point in the history

  11. Updated license to Apache 2.0

    @pabloruiz55
    pabloruiz55 authored May 31, 2019
    Configuration menu
    Copy the full SHA
    647ff51 View commit details
    Browse the repository at this point in the history

  12. Update LICENSE

    @pabloruiz55
    pabloruiz55 authored May 31, 2019
    Configuration menu
    Copy the full SHA
    c9b89c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. [3.20] Don't ask for name when registering ticker (#706) 

    * Removed storing token name when registering ticker

* Added backwards compatible functions

* Updated tests to use latest functions

* Renamed functions for easy testing on truffle

* Fixed test
    @maxsam4
    maxsam4 authored Jun 12, 2019
    Configuration menu
    Copy the full SHA
    b22c7bc View commit details
    Browse the repository at this point in the history

  2. [3.38]: Add ST storage layout check script in CI pipeline (#704) 

    * add st storage layout check script in CI pipeline

* add info comment
    @satyamakgec @maxsam4
    satyamakgec authored and maxsam4 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    115edb6 View commit details
    Browse the repository at this point in the history

  3. 3.30 Remove OwnedProxy (#701) 

    * Audit fix

* Fix

* Moved variable to storage contract
    @adamdossa @maxsam4
    adamdossa authored and maxsam4 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    12ed7b3 View commit details
    Browse the repository at this point in the history

  4. [3.31] Removed take usage fee (#700) 

    * Removed takeUsageFee

* Test fix

* tests fixed
    @maxsam4
    maxsam4 authored Jun 12, 2019
    Configuration menu
    Copy the full SHA
    cbf785d View commit details
    Browse the repository at this point in the history

  5. [3.5, 3.7, 3.8] Fix custom modules (#698) 

    * Fix custom modules

* Remove unnecessary modifier

* Fix some test cases
    @adamdossa @maxsam4
    adamdossa authored and maxsam4 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    10c1d62 View commit details
    Browse the repository at this point in the history

  6. disallow creation of 0 supply dividend (#697)

    @maxsam4
    maxsam4 authored Jun 12, 2019
    Configuration menu
    Copy the full SHA
    90199cb View commit details
    Browse the repository at this point in the history

  7. Added break in deleteDelegate (#696)

    @maxsam4
    maxsam4 authored Jun 12, 2019
    Configuration menu
    Copy the full SHA
    3cb9829 View commit details
    Browse the repository at this point in the history

  8. Added 0 length name check (#695)

    @maxsam4
    maxsam4 authored Jun 12, 2019
    Configuration menu
    Copy the full SHA
    004194e View commit details
    Browse the repository at this point in the history

  9. Audit 3.4 & 3.14 Fix ST upgrades (#694) 

    * Fixes + test cases

* Small change in test

* Add fixes for 3.14
    @adamdossa @maxsam4
    adamdossa authored and maxsam4 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    045ccc1 View commit details
    Browse the repository at this point in the history

  10. Fix setProtocolFactory() (#689)

    @satyamakgec @maxsam4
    satyamakgec authored and maxsam4 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    dcea2c4 View commit details
    Browse the repository at this point in the history

  11. Remove inconsistency of the index value (#688)

    @satyamakgec @maxsam4
    satyamakgec authored and maxsam4 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    0ae44d0 View commit details
    Browse the repository at this point in the history

  12. remove the unneccessary code from partitionsOf() (#681)

    @satyamakgec @maxsam4
    satyamakgec authored and maxsam4 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    8f31ea9 View commit details
    Browse the repository at this point in the history

  13. Added constructors (#672) 

    * Added constructors
The constructors prevents an exploit in case we forget to initialize the implementation contracts.
Ideally, we should allways remember to initialize implementation contracts as well.

* Migration fixed

* test fix

* test fix

* Add the ability to configure the new STR atomically
    @maxsam4
    maxsam4 authored Jun 12, 2019
    Configuration menu
    Copy the full SHA
    f71bfa3 View commit details
    Browse the repository at this point in the history

  14. Fix the returnPartition function (#680) 

    * fix the returnPartition function

* minor fix
    @satyamakgec @maxsam4
    satyamakgec authored and maxsam4 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    3176359 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. Remove comment from codebase (#714)

    @adamdossa
    adamdossa authored Jun 13, 2019
    Configuration menu
    Copy the full SHA
    4dc6c5c View commit details
    Browse the repository at this point in the history

  2. Update interfaces to named parameters (#708) 

    * WIP

* Change some values

* Make some mappings public for automatic getters

* Put back truffle version
    @adamdossa
    adamdossa authored Jun 13, 2019
    Configuration menu
    Copy the full SHA
    99cf720 View commit details
    Browse the repository at this point in the history

  3. updated transfer manager results (#693)

    @maxsam4 @adamdossa
    maxsam4 authored and adamdossa committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    0e8c7cd View commit details
    Browse the repository at this point in the history

  4. Allow Custom oracle in USDTieredSTO (#691) 

    * Added custom oracles to USDTSTO

* Updated custom oracles logic
    @maxsam4 @adamdossa
    maxsam4 authored and adamdossa committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    d29863c View commit details
    Browse the repository at this point in the history

  5. Pinned solidity version (#675) 

    * Pinned solidity version

* Fix merge conflicts
    @maxsam4 @adamdossa
    maxsam4 authored and adamdossa committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    3ff1d69 View commit details
    Browse the repository at this point in the history

  6. minor transfer optimization (#668)

    @maxsam4 @adamdossa
    maxsam4 authored and adamdossa committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    95338da View commit details
    Browse the repository at this point in the history

  7. Fix the BalanceOfPartition audit item (#679) 

    * fix balance of partition function

* fix balance of Partition function

* return balance in the parent implementation of the getTokensByPartition()
    @satyamakgec @adamdossa
    satyamakgec authored and adamdossa committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    2706d20 View commit details
    Browse the repository at this point in the history

  8. Extra Items (#702) 

    * minor improvements

* permission fixes
    @satyamakgec @adamdossa
    satyamakgec authored and adamdossa committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    9fae133 View commit details
    Browse the repository at this point in the history

  9. Synchronise the ISTR with STR (#682) 

    * synchronise the ISTR with STR

* fix the interface problem

* minor fixes

* add some function in interface

* add comment in STR

* consistency in interfaces of contracts

* improve the st interface

* remove shadow declaration

* add #706 new function declartion in the ISTR

* add missing functions in interface
    @satyamakgec @adamdossa
    satyamakgec authored and adamdossa committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    6d61c1c View commit details
    Browse the repository at this point in the history

  10. Specific contract type used (#683) 

    * specific contract type used

* add more type contract

* remove the redundant KindMath

* remove unnecessary casting

* Merge fixes
    @satyamakgec @adamdossa
    satyamakgec authored and adamdossa committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    5436247 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Fix PLCR Proposal inconsistency (#713) 

    * fix the proposal

* minor styling and comments addition

* Fix contract size issue.
    @satyamakgec @adamdossa
    satyamakgec authored and adamdossa committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    1cd43e8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev-3.0.0' into audit-fixes

    @adamdossa
    adamdossa authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    4fdc1c1 View commit details
    Browse the repository at this point in the history

  3. Update licenses - Apache 2.0 

    As per https://spdx.org/licenses/
    @adamdossa
    adamdossa committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    884d5a6 View commit details
    Browse the repository at this point in the history

  4. Fix canTransfer spec (#709) 

    * Fix spec

* Fix conflict

* Fix merge conflict

* Small fixes

* Revert package.json change

* Fix test case
    @adamdossa
    adamdossa authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    95be076 View commit details
    Browse the repository at this point in the history

  5. Set solcjs as default compiler (#716) 

    * Set solcjs as default compiler
If you want to use native solc, set the environemnt variable POLYMATH_NATIVE_SOLC as true.

* Removed native solc from travis

* Removed native solc version query from travis
    @maxsam4
    maxsam4 authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    2673164 View commit details
    Browse the repository at this point in the history