-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track non-zero account holders #95
Conversation
… number of investors
# Conflicts: # contracts/modules/TransferManager/ExchangeTransferManager.sol # contracts/modules/TransferManager/GeneralTransferManager.sol # contracts/modules/TransferManager/ITransferManager.sol # contracts/tokens/SecurityToken.sol
|
||
contract CountTransferManager is ITransferManager { | ||
|
||
uint256 public holderCount; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this to maxHolderCount or holderCountLimit? readability purposes only.
contract PercentageTransferManager is ITransferManager { | ||
using SafeMath for uint256; | ||
|
||
uint256 public holderPercentage; // percentage multiplied by 10**16 - e.g. 20% is 20 * 10**16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this to maxHolderPercentage or holderPercentageLimit?
WIP - needs test cases