burn securities #99
Merged
burn securities #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdossa
reviewed
May 9, 2018
contracts/tokens/SecurityToken.sol
Outdated
| event LogGranularityChanged(uint256 _oldGranularity, uint256 _newGranularity); | ||
| event LogModuleRemoved(uint8 indexed _type, address _module, uint256 _timestamp); | ||
| event LogModuleBudgetChanged(uint8 indexed _moduleType, address _module, uint256 _budget); | ||
| event Mint(address indexed to, uint256 amount); | ||
| event Burn(address indexed _burner, uint256 _value); |
There was a problem hiding this comment.
Can we change event names to:
Minted
Burnt
this keeps naming consistent (past tense) and differentiates a bit from the same function names.
There was a problem hiding this comment.
Maybe also move these events into IST20.sol?
contracts/tokens/SecurityToken.sol
Outdated
|
|
||
| function burn(uint256 _value) checkGranularity(_value) public { | ||
| require(tokenBurner != address(0), "Token Burner contract address is not set yet"); | ||
| require(_value <= balances[msg.sender], "Value should no be greater than the balance of meg.sender"); |
There was a problem hiding this comment.
msg.sender rather than meg.sender
pabloruiz55
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.