Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phone number formatting to Input component (GTN-87) #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Phone number formatting to Input component (GTN-87) #22

wants to merge 2 commits into from
+21 −3

Conversation

MehdiRaash
Copy link
Member

No description provided.

@honarpour
Copy link
Contributor

honarpour commented Sep 30, 2021 •
edited
Loading

Looks good. However, in designs we show the country flag of entered phone number. I think doing phone as variant would work better, and based on that we can render the country flag. Checkout Polymesh UI, we were using a package for phone numbers that showed flag out of box, and hopefully just do <Component as={isAmount ? NumberInput : isPhone ? PhoneInput : 'input'} />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MehdiRaash @honarpour