Handle spaces in paths in fs-resolver

Fixes Polymer/polymer-starter-kit#62

lib/loader/fs-resolver.js

@@ -68,7 +68,7 @@ FSResolver.prototype = {
   accept: function(uri, deferred) {
     var parsed = url.parse(uri);
     var host = this.config.host;
-    var base = this.config.basePath;
+    var base = this.config.basePath && decodeURIComponent(this.config.basePath);
     var root = this.config.root && path.normalize(this.config.root);
     var redirect = this.config.redirect;
 
@@ -79,6 +79,9 @@ FSResolver.prototype = {
     }
 
     if (local) {
+      // un-escape HTML escapes
+      local = decodeURIComponent(local);
+
       if (base) {
         local = path.relative(base, local);
       }

package.json

@@ -34,7 +34,7 @@
     "watch": "latest"
   },
   "dependencies": {
-    "dom5": "^1.0.3",
+    "dom5": "^1.1.0",
     "es6-promise": "^2.1.0",
     "espree": "^2.0.1",
     "estraverse": "^3.1.0",

test/static/spaces in request.txt

@@ -0,0 +1 @@
+Spaces!

test/test.js

@@ -103,6 +103,27 @@ suite('Loader', function() {
         assert.equal(content.trim(), 'Hello!');
       }).then(done, done);
     });
+
+    test('Spaces in Filepath', function(done) {
+      var fs = new fsResolver({
+        root: path.join(__dirname, '..')
+      });
+      l.addResolver(fs);
+      l.request('/test/static/spaces%20in%20request.txt').then(function(content) {
+        assert.equal(content.trim(), 'Spaces!');
+      }).then(done, done);
+    });
+
+    test('Spaces in Filepath', function(done) {
+      var fs = new fsResolver({
+        root: path.join(__dirname, '..'),
+        basePath: '/space%20in%20basePath'
+      });
+      l.addResolver(fs);
+      l.request('/space%20in%20basePath/test/static/xhr-text.txt').then(function(content) {
+        assert.equal(content.trim(), 'Hello!');
+      }).then(done, done);
+    });
   });
 
   suite('Noop Resolver', function() {