Add shared styles #328
Add shared styles #328
Conversation
chuckh
force-pushed
the
add-shared-styles
branch
from
5936afe to
1d99963
Compare
| @@ -8,22 +8,14 @@ | |||
| subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt | |||
| --> | |||
|
|
|||
| <link rel="import" href="../../styles/shared-styles.html"> | |||
There was a problem hiding this comment.
Is this line needed as it's already being imported in the elements.html?
There was a problem hiding this comment.
Good catch. No it is not needed. I will remove.
|
Thanks for throwing this together, @chuckh. I've been reviewing Polymer/polymer#1876 Polymer/polymer#2229 (comment) & Polymer/polymer#2198 to catch up on the new approach. Your changes LGTM here, however testing locally with 1.1.1 I'm seeing some differences between Chrome and Safari (Mac): I've verified that master otherwise appears to be fine: Could you do another pass on testing the change out to see what might be causing the discrepancy? |
|
@addyosmani did some more testing this morning. It worked for my on Chrome and Safari, but got the same results as you did but with Firefox instead. I was using 1.1.1, but then I decide to try doing a bower update and that fixed it. Try doing bower update then try testing again. Results after bower update:Safari (8.0.8 mac): Firefox (40.0 mac): Chrome (44.0.2403 mac) |
Add the new Polymer 1.1.0 share styles approach. Remove commented css Remove import from my-greeting.html This import is not need because it is in elements.html. Remove an accidentally added word
chuckh
force-pushed
the
add-shared-styles
branch
2 times, most recently
from
55c7210 to
dc64fa5
Compare
chuckh
force-pushed
the
add-shared-styles
branch
from
dc64fa5 to
0b7d564
Compare
|
LGTM |
Add the new Polymer 1.1.0 share styles approach. Addresses #267.