Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.9] Touch scroll gesture, setScrollDirection doesn't work any longer #1520

Closed
IntranetFactory opened this issue May 12, 2015 · 4 comments
Closed

Comments

@IntranetFactory
Copy link

After applying 617093c from @azakus touch track works, but it seems that now touch scroll doesn't work any longer. In the previous version node.setScrollDirection('y'); enabled vertical scroll, which seems to not work any longer.

Should setScrollDirection work as before or did anything change?

@IntranetFactory
Copy link
Author

It seems to work for me when I switch pan-x and pan-y checks

        } else if (ta === 'pan-y') {
          prevent = dx >= dy;
        } else if (ta === 'pan-x') {
          prevent = dy > dx;
        }

@dfreedm
Copy link
Member

dfreedm commented May 13, 2015

Whoops, thanks for the insight.

dfreedm added a commit that referenced this issue May 13, 2015
@dfreedm dfreedm closed this as completed May 13, 2015
@bendavis78
Copy link

This still seems to be broken, at least in my use case. See the following jsbin: http://output.jsbin.com/nisoru. (you'll need to view it on a touch-capable display or using the chrome mobile emulator).

The list items are set up to respond to horizontal swipes, however the list will not scroll vertically, even when this.setScrollDirection('y') is used. The only way to allow vertical scrolling is to remove on-track from the element.

@bendavis78
Copy link

Scratch that last comment. I figured out I had to add setScrollDirection before the touch event, as well as pass the 2nd parameter for the target. I've updated the jsbin in case anyone else ends up here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants