Fix using value$ on input element #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
force-pushed
the
input-value-annotated
branch
from
0f0ece1
to
05a1e95
Compare
|
👍 |
1 similar comment
|
👍 |
|
👍 |
|
👍 |
|
👍 |
|
LGTM. 👍 Thanks @JeremybellEU! |
kevinpschaaf
added a commit
that referenced
this pull request
Nov 18, 2015
Fix using value$ on input element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was thrown because of a specific edge case for
<input value$="">. This check was introduced in #1589 for #1578 and latest modified on a300862#diff-870cfe064a36c23b69e8da891fdff6beR299For both
value$andvaluename === 'value'. However, if it was originallyvalue$it should not be executed. Therefore the check should be changed toorigName === 'value'.Fixes #2666