Fix getNamespace() and show protected methods in Polymer 1.x (#161)

PolymerElements · Jun 27, 2017 · 70bfdeb · 70bfdeb
1 parent 7e75aeb
commit 70bfdeb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/iron-doc-api.html b/iron-doc-api.html
@@ -84,7 +84,7 @@ <h2>
         </iron-doc-function>
       </template>
 
-      <template is="dom-if" if="[[_protectedCount(descriptor.methods, descriptor.staticMethods)]]">
+      <template is="dom-if" if="[[_protectedCount(descriptor.methods, _staticMethods)]]">
         <template is="dom-if" if="[[_showProtectedMethods]]">
           <template is="dom-repeat"
                     items="[[_protected(descriptor.staticMethods)]]"
@@ -104,7 +104,7 @@ <h2>
         </template>
 
         <iron-doc-hide-bar visible="{{_showProtectedMethods}}">
-          [[_protectedCount(descriptor.methods, descriptor.staticMethods)]]
+          [[_protectedCount(descriptor.methods, _staticMethods)]]
           protected methods
         </iron-doc-hide-bar>
       </template>
@@ -153,7 +153,11 @@ <h2>
         properties: {
           _showProtectedProperties: Boolean,
           _showProtectedMethods: Boolean,
-          _showProtectedEvents: Boolean
+          _showProtectedEvents: Boolean,
+
+          _staticMethods: {
+            computed: '_computeStaticMethods(descriptor)'
+          }
         },
 
         _anyVisible: function(items) {
@@ -194,7 +198,11 @@ <h2>
             sum += this._protected(arguments[i]).length
           }
           return sum;
-        }
+        },
+
+        _computeStaticMethods: function(descriptor) {
+          return descriptor.staticMethods || [];
+        },
       });
     })();
   </script>

diff --git a/iron-doc-viewer.html b/iron-doc-viewer.html
@@ -361,18 +361,18 @@
         parts = parts.slice(0, parts.length - 1);
         var namespace = descriptor;
 
-        parts.forEach(function(part) {
+        for (var i = 0; i < parts.length; i++) {
           if (!namespace.namespaces) {
             return undefined;
           }
           var matches = namespace.namespaces.filter(function(n) {
-            return n.name === part;
+            return n.name === parts[i];
           });
           if (matches.length === 0) {
             return undefined;
           }
           namespace = matches[0];
-        });
+        };
         return namespace;
       }
     })();