Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sanitizer option. #74

Merged
merged 4 commits into from
Aug 15, 2017
Merged

add sanitizer option. #74

merged 4 commits into from
Aug 15, 2017

Conversation

howking
Copy link
Contributor

@howking howking commented Aug 10, 2017

undocumented markedjs/marked#468, but useful option.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@howking
Copy link
Contributor Author

howking commented Aug 10, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@howking
Copy link
Contributor Author

howking commented Aug 11, 2017

This is sample for use.
https://github.com/howking/sanitize-element

<sanitize-element config='{
  "elements":["a","img"],
  "attributes":{"a":["href","title"],"img":["src"]},
  "protocols":{"a":{"href":["http","https"]}}
  }' sanitizer="{{sanitizer}}"></sanitize-element>

<marked-element markdown="[[markdown]]" sanitize sanitizer="[[sanitizer]]">

@stramel
Copy link
Collaborator

stramel commented Aug 15, 2017

I'm good with allowing this pass-through but it should have tests supporting it and a better description of the property.

Would be good to get @e111077's input too.

@howking
Copy link
Contributor Author

howking commented Aug 15, 2017

thanks !
I added tests and desc.

@e111077
Copy link
Contributor

e111077 commented Aug 15, 2017

I gotta say; I really love this feature! Thanks a lot for the submission, @howking!

@e111077 e111077 merged commit 84831af into PolymerElements:master Aug 15, 2017
@stramel
Copy link
Collaborator

stramel commented Aug 16, 2017

🎉 thanks @howking! Released with 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants