Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2.0 #3

Merged
merged 66 commits into from
Mar 30, 2017
Merged

Use 2.0 #3

merged 66 commits into from
Mar 30, 2017

Conversation

valdrinkoshi
Copy link
Collaborator

@valdrinkoshi valdrinkoshi commented Sep 16, 2016

The main change is moving to Polymer 2.0, which allows using es6 classes and the new templatizer (which removes the need mirroring properties to the renderer and just use the data binding system 🎉 )

Also:

  • renderers are stamped to <body> if no-one prevents the attach/detach events
  • events are managed by a shared event listener which delegates the event to the last registered element (moved logic away from iron-overlay-container, which makes it optional)
  • events are delegated to the interested overlay, e.g. overlay with noCancelOnOutsideClick will be skipped, overlay below it (if any) will handle the tap event
  • made renderer public readonly property (fixes overlay should expose renderer property #4)
  • implemented restore focus on close functionality
  • added shared styles
  • added tests
  • merged iron-animated-overlay (and renderer) into iron-overlay, added property animated

Currently in ShadyDom the renderer is not rendered correctly because of webcomponents/shadycss#17

@valdrinkoshi
Copy link
Collaborator Author

@cdata PTAL (don't get scared of the big changes 🍰 )

@valdrinkoshi valdrinkoshi merged commit 2f20d8b into master Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overlay should expose renderer property
3 participants