Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Remove db-max-total-wal-size arg for older chain #81

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

prashantasdeveloper
Copy link
Collaborator

Description

For chain version < 5.1.3, this arguments errors preventing polymesh-local from starting up

USAGE:

    polymesh --base-path <PATH> --unsafe-ws-external --unsafe-rpc-external --wasm-execution <METHOD> --no-prometheus --no-telemetry --pruning <PRUNING_MODE> --no-mdns --validator --rpc-cors <ORIGINS> --rpc-methods <METHOD SET> --force-authoring


For more information try --help

error: Found argument '--db-max-total-wal-size' which wasn't expected, or isn't valid in this context

This PR conditionally adds the argument to later chain versions.

FYI, the argument was added here - #72

Breaking Changes

JIRA Link

Checklist

  • Updated the Readme.md (if required) ?

@prashantasdeveloper
Copy link
Collaborator Author

This will free up the broken CI in SQ PR - PolymeshAssociation/polymesh-subquery#162

@prashantasdeveloper prashantasdeveloper merged commit 107c7bf into master Aug 10, 2023
3 checks passed
@prashantasdeveloper prashantasdeveloper deleted the fix/remove-db-wal-size-arg branch August 10, 2023 13:47
@prashantasdeveloper
Copy link
Collaborator Author

🎉 This PR is included in version 5.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants