feat: 🎸 Return balance info when applying incoming balance #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: 🧨 On applying incoming balance(s) for an account, the method now returns details about the confidential asset, the amount being applied and balance after amount is deposited. - `confidentialAccounts.applyIncomingBalance` returns `IncomingConfidentialAssetBalance` - `confidentialAccounts.applyIncomingBalances` returns `IncomingConfidentialAssetBalance[]`
prashantasdeveloper
force-pushed
the
feat/DA-1264
branch
from
97fbe6f
to
81e5c1d
Compare
|
sansan
approved these changes
Jul 26, 2024
|
/fast-forward |
|
🎉 This PR is included in version 2.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return balance info when applying incoming balance
Breaking Changes
On applying incoming balance(s) for an account, the method now returns details about the confidential asset, the amount being applied and balance after amount is deposited.
confidentialAccounts.applyIncomingBalancereturnsIncomingConfidentialAssetBalanceconfidentialAccounts.applyIncomingBalancesreturnsIncomingConfidentialAssetBalance[]JIRA Link
DA-1264
Checklist