-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py speedup1 #1840
base: master
Are you sure you want to change the base?
Py speedup1 #1840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: bf28e57 | Previous: 85a9eab | Ratio |
---|---|---|---|
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0 ) |
2 ns/iter (± 0 ) |
2.50 |
lotr_graph_persistent_window_50_layered/iterate nodes |
14703 ns/iter (± 16 ) |
7311 ns/iter (± 7 ) |
2.01 |
This comment was automatically generated by workflow using github-action-benchmark.
…we don't use it anyway
I'm a bit puzzled about the benchmarks, this is what I'm getting
|
What changes were proposed in this pull request?
Add numpy to python properties when we can
Why are the changes needed?
because rust -> python is sometimes slow
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Issues
closes #1839
Are there any further changes required?