Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py speedup1 #1840

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Py speedup1 #1840

wants to merge 24 commits into from

Conversation

fabianmurariu
Copy link
Contributor

What changes were proposed in this pull request?

Add numpy to python properties when we can

Why are the changes needed?

because rust -> python is sometimes slow

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Issues

closes #1839

Are there any further changes required?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: bf28e57 Previous: 85a9eab Ratio
lotr_graph_subgraph_10pc/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_persistent_window_50_layered/iterate nodes 14703 ns/iter (± 16) 7311 ns/iter (± 7) 2.01

This comment was automatically generated by workflow using github-action-benchmark.

@fabianmurariu
Copy link
Contributor Author

I'm a bit puzzled about the benchmarks, this is what I'm getting

lotr_graph_window_50_layered/iterate nodes
                        time:   [7.1942 µs 7.2791 µs 7.3649 µs]
                        change: [-28.904% -26.641% -24.581%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild

  2024-10-27T20:20:18.813714Z  INFO raphtory_benchmark::common: Num layers 5, node count: 139, edge_count: 701
    at raphtory-benchmark/src/common/mod.rs:275

lotr_graph_persistent_window_50_layered/iterate nodes
                        time:   [8.3778 µs 8.4859 µs 8.5862 µs]
                        change: [-32.056% -30.450% -28.763%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild

graph: Graph(num_nodes=139, num_edges=701)
graph: Graph(num_nodes=139, num_edges=701)
murariuf@fedora ~/S/raphtory (py_speedup1)> cargo bench --bench base --bench base -p raphtory-benchmark "iterate nodes" -- --baseline py_speedup1 --load-baseline master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small python improvements
1 participant