Add conversion counter increase to PHP side of form integration

Issue #775
PopupMaker · Oct 9, 2020 · 3965e98 · 3965e98
1 parent 6f89bac
commit 3965e98
Show file tree

Hide file tree

Showing 7 changed files with 103 additions and 12 deletions.
diff --git a/classes/Integration/Form/CalderaForms.php b/classes/Integration/Form/CalderaForms.php
@@ -63,8 +63,20 @@ public function get_form_selectlist() {
 	 * @param array $form
 	 */
 	public function on_success( $form ) {
+		if ( ! isset( $_REQUEST['pum_form_popup_id'] ) ) {
+			return;
+		}
+
+		$popup_id = absint( $_REQUEST['pum_form_popup_id'] );
+		if ( 0 === $popup_id ) {
+			return;
+		}
+
+		$popup = pum_get_popup( $popup_id );
+		$popup->increase_event_count( 'conversion' );
+
 		pum_integrated_form_submission( [
-			'popup_id'      => isset( $_REQUEST['pum_form_popup_id'] ) && absint( $_REQUEST['pum_form_popup_id'] ) > 0 ? absint( $_REQUEST['pum_form_popup_id'] ) : false,
+			'popup_id'      => $popup_id,
 			'form_provider' => $this->key,
 			'form_id'       => $form['ID'],
 		] );

diff --git a/classes/Integration/Form/ContactForm7.php b/classes/Integration/Form/ContactForm7.php
@@ -87,11 +87,21 @@ public function get_form_selectlist() {
 	 * @param WPCF7_ContactForm $cfdata
 	 */
 	public function on_success( $cfdata ) {
-		/**
-		 * @see pum_integrated_form_submission
-		 */
+
+		if ( ! isset( $_REQUEST['pum_form_popup_id'] ) ) {
+			return;
+		}
+
+		$popup_id = absint( $_REQUEST['pum_form_popup_id'] );
+		if ( 0 === $popup_id ) {
+			return;
+		}
+
+		$popup = pum_get_popup( $popup_id );
+		$popup->increase_event_count( 'conversion' );
+
 		pum_integrated_form_submission( [
-			'popup_id'      => isset( $_REQUEST['pum_form_popup_id'] ) && absint( $_REQUEST['pum_form_popup_id'] ) > 0 ? absint( $_REQUEST['pum_form_popup_id'] ) : false,
+			'popup_id'      => $popup_id,
 			'form_provider' => $this->key,
 			'form_id'       => $cfdata->id(),
 		] );

diff --git a/classes/Integration/Form/FormidableForms.php b/classes/Integration/Form/FormidableForms.php
@@ -95,10 +95,21 @@ public function on_success( $entry_id, $form_id ) {
 			return;
 		}
 
-		// @see pum_integrated_form_submission
+		if ( ! isset( $_REQUEST['pum_form_popup_id'] ) ) {
+			return;
+		}
+
+		$popup_id = absint( $_REQUEST['pum_form_popup_id'] );
+		if ( 0 === $popup_id ) {
+			return;
+		}
+
+		$popup = pum_get_popup( $popup_id );
+		$popup->increase_event_count( 'conversion' );
+
 		pum_integrated_form_submission(
 			[
-				'popup_id'      => isset( $_REQUEST['pum_form_popup_id'] ) && absint( $_REQUEST['pum_form_popup_id'] ) > 0 ? absint( $_REQUEST['pum_form_popup_id'] ) : false,
+				'popup_id'      => $popup_id,
 				'form_provider' => $this->key,
 				'form_id'       => $form_id,
 			]

diff --git a/classes/Integration/Form/GravityForms.php b/classes/Integration/Form/GravityForms.php
@@ -65,8 +65,20 @@ public function get_form_selectlist() {
 	 * @param $form
 	 */
 	public function on_success( $entry, $form ) {
+		if ( ! isset( $_REQUEST['pum_form_popup_id'] ) ) {
+			return;
+		}
+
+		$popup_id = absint( $_REQUEST['pum_form_popup_id'] );
+		if ( 0 === $popup_id ) {
+			return;
+		}
+
+		$popup = pum_get_popup( $popup_id );
+		$popup->increase_event_count( 'conversion' );
+
 		pum_integrated_form_submission( [
-			'popup_id'      => isset( $_REQUEST['pum_form_popup_id'] ) && absint( $_REQUEST['pum_form_popup_id'] ) > 0 ? absint( $_REQUEST['pum_form_popup_id'] ) : false,
+			'popup_id'      => $popup_id,
 			'form_provider' => $this->key,
 			'form_id'       => $form['id'],
 		] );

diff --git a/classes/Integration/Form/NinjaForms.php b/classes/Integration/Form/NinjaForms.php
@@ -65,8 +65,21 @@ public function get_form_selectlist() {
 	 */
 	public function on_success_v2() {
 		global $ninja_forms_processing;
+
+		if ( ! isset( $_REQUEST['pum_form_popup_id'] ) ) {
+			return;
+		}
+
+		$popup_id = absint( $_REQUEST['pum_form_popup_id'] );
+		if ( 0 === $popup_id ) {
+			return;
+		}
+
+		$popup = pum_get_popup( $popup_id );
+		$popup->increase_event_count( 'conversion' );
+
 		pum_integrated_form_submission( [
-			'popup_id'      => isset( $_REQUEST['pum_form_popup_id'] ) && absint( $_REQUEST['pum_form_popup_id'] ) > 0 ? absint( $_REQUEST['pum_form_popup_id'] ) : false,
+			'popup_id'      => $popup_id,
 			'form_provider' => $this->key,
 			'form_id'       => $ninja_forms_processing->get_form_ID(),
 		] );
@@ -76,8 +89,19 @@ public function on_success_v2() {
 	 * @param $form_data
 	 */
 	public function on_success_v3( $form_data ) {
+		if ( ! isset( $_REQUEST['pum_form_popup_id'] ) ) {
+			return;
+		}
+
+		$popup_id = absint( $_REQUEST['pum_form_popup_id'] );
+		if ( 0 === $popup_id ) {
+			return;
+		}
+
+		$popup = pum_get_popup( $popup_id );
+		$popup->increase_event_count( 'conversion' );
 		pum_integrated_form_submission( [
-			'popup_id'      => isset( $_REQUEST['pum_form_popup_id'] ) && absint( $_REQUEST['pum_form_popup_id'] ) > 0 ? absint( $_REQUEST['pum_form_popup_id'] ) : false,
+			'popup_id'      => $popup_id,
 			'form_provider' => $this->key,
 			'form_id'       => $form_data['form_id'],
 		] );

diff --git a/classes/Integration/Form/PirateForms.php b/classes/Integration/Form/PirateForms.php
@@ -127,8 +127,19 @@ public function get_form_selectlist() {
 	 * @param int $entry_id Entry ID. Will return 0 if entry storage is disabled or using WPForms Lite.
 	 */
 	public function on_success( $fields, $entry, $form_data, $entry_id ) {
+		if ( ! isset( $_REQUEST['pum_form_popup_id'] ) ) {
+			return;
+		}
+
+		$popup_id = absint( $_REQUEST['pum_form_popup_id'] );
+		if ( 0 === $popup_id ) {
+			return;
+		}
+
+		$popup = pum_get_popup( $popup_id );
+		$popup->increase_event_count( 'conversion' );
 		pum_integrated_form_submission( [
-			'popup_id'      => isset( $_REQUEST['pum_form_popup_id'] ) && absint( $_REQUEST['pum_form_popup_id'] ) > 0 ? absint( $_REQUEST['pum_form_popup_id'] ) : false,
+			'popup_id'      => $popup_id,
 			'form_provider' => $this->key,
 			'form_id'       => $form_data['id'],
 		] );

diff --git a/classes/Integration/Form/WPForms.php b/classes/Integration/Form/WPForms.php
@@ -70,8 +70,19 @@ public function get_form_selectlist() {
 	 * @param int $entry_id Entry ID. Will return 0 if entry storage is disabled or using WPForms Lite.
 	 */
 	public function on_success( $fields, $entry, $form_data, $entry_id ) {
+		if ( ! isset( $_REQUEST['pum_form_popup_id'] ) ) {
+			return;
+		}
+
+		$popup_id = absint( $_REQUEST['pum_form_popup_id'] );
+		if ( 0 === $popup_id ) {
+			return;
+		}
+
+		$popup = pum_get_popup( $popup_id );
+		$popup->increase_event_count( 'conversion' );
 		pum_integrated_form_submission( [
-			'popup_id'      => isset( $_REQUEST['pum_form_popup_id'] ) && absint( $_REQUEST['pum_form_popup_id'] ) > 0 ? absint( $_REQUEST['pum_form_popup_id'] ) : false,
+			'popup_id'      => $popup_id,
 			'form_provider' => $this->key,
 			'form_id'       => $form_data['id'],
 		] );