Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from master #854

Merged
merged 17 commits into from
Jul 16, 2020
Merged

Update from master #854

merged 17 commits into from
Jul 16, 2020

Conversation

fpcorso
Copy link
Contributor

@fpcorso fpcorso commented Jul 16, 2020

Update develop with changes from master

@fpcorso fpcorso merged commit 6ff8fb1 into develop Jul 16, 2020
@danieliser
Copy link
Member

danieliser commented Jul 17, 2020

@fpcorso Was this a manual merge of a previous release? If so you should really install git-flow. These shouldn't be done from master, but rather from the tag of the version created off of master for the release.

Example: 1675b7b

@fpcorso
Copy link
Contributor Author

fpcorso commented Jul 20, 2020

@danieliser Normally, I would have gone from the tag of the version created but I also wanted to merge the new issue and pull request templates as I wanted to add to them as I completed other tasks during the 1.12 release which is why I merged from master for this one instead.

Was there a better way to achieve that?

@danieliser
Copy link
Member

@fpcorso Ahh, probably the "right" way would have been to make them features off of develop and merge them when we did a normal release, but this may be an exception to the rule as that doesn't fit the normal flows.

@danieliser
Copy link
Member

Next time maybe just merge the tag like normal, then merge your side branches and then back merge master again into develop.

This way the normal release flow stays in tact and you can push changes directly to master and back to develop without worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants