Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PulseAudio Portaudio HostAPI #336
PulseAudio Portaudio HostAPI #336
Changes from all commits
c96df06
8371055
c99c40c
7cee797
55418fa
471031e
f865303
bd17afc
ab76ef1
1dd1465
9368f0f
94b18b2
8118be4
a33b944
ef4b99c
e4d2728
1ea9991
7e27996
577a56d
9f2a6b7
8f98cdd
0a4690b
81dec9f
9fceb73
fb931b2
b91a92c
c29c70d
ecabd50
4f488b8
e129062
b823cb2
feed80a
dcd47e2
c57eff8
9d9b732
b4e290e
20c9604
5233622
e0d712d
5224636
6690a9b
02d6885
5db214a
2b51c75
0e7ca8e
e142ca4
9e7b5d8
a16c38d
595c7f3
f8fedd2
0d71183
c5ff701
480fd90
03d1075
91d2981
ec0c2df
092bee5
37bd590
e15197a
2e47294
1720b9c
f04fbad
7874057
ee0dd99
758a081
88eb1ff
eb6b4e9
d1b4a8e
6dcc74e
b02288c
01a842d
cb2b5dd
591cf43
4d452f4
819cfd0
89836c4
a88cc9c
7348043
86be880
fde7812
9d0510d
cc1194e
b7a30e8
dd4a69a
86d4581
8be4b78
b1bac8b
29db3e3
fff12f4
1517c30
5f88f27
f8b2d24
b3271c2
9425307
e98ed6a
8b658bd
aecbe43
d3b3c5e
7b2fc07
fef040d
f2b1beb
d3106b1
e70ef87
b775bb0
66a3329
c454c37
5b98b38
5864a7f
600b952
a1e1049
19ca2df
5b5c08d
5ffbe99
069213c
b263b8a
535538d
7cf4af9
ab656ba
f8fdbdf
4e3f10f
8a84e9f
001ac5c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will add
pa_linux_pulsaudio.h
even if only$have_jack
is yes. Is that what you want?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is merged now, but I'd still like to get clarification about whether this has the intended behavior please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be copy paste.. I'll make PR to solve this. I think it should be something like
"$have_pulse" = "yes" ] && [ "$with_pulse" != "no"
or just merge it to one to rule them all if. I have to admit I use CMake so this was not tested very deeply.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now there is pull request with small fix to make it work. Jack and Pulseaudio needs ringbuffer so it's just merged together.