pa_converters include math if PA_USE_C99_LRINTF #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBencina
approved these changes
Dec 22, 2020
|
FYI here's what I think about the |
|
This is pending some consensus on #390. I think either we merge this PR or we strip out the |
|
I think we should close this and then remove the PA_USE_C99_LRINTF code. |
|
I've submitted #403 as an alternative to this. I'll close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pa_converters.c did not include math.h in case PA_USE_C99_LRINTF is defined
so the compiler could not find the definition for lrintf